Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-424] Port chia wallet coins to @tx_out_cmd #18023

Merged
merged 1 commit into from
May 16, 2024

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented May 15, 2024

This brings another set of commands to the @tx_out_cmd decorator which gives it the capability to optionally push a transaction and export the transactions to a local file.

@Quexington Quexington added Added Required label for PR that categorizes merge commit message as "Added" for changelog vault labels May 15, 2024
@Quexington Quexington marked this pull request as ready for review May 15, 2024 19:08
@Quexington Quexington requested a review from a team as a code owner May 15, 2024 19:08
Copy link
Contributor

File Coverage Missing Lines
chia/cmds/coin_funcs.py 47.1% lines 139, 142, 169, 172, 185, 216, 222, 225, 239
Total Missing Coverage
25 lines 9 lines 64%

AmineKhaldi
AmineKhaldi previously approved these changes May 15, 2024
emlowe
emlowe previously approved these changes May 15, 2024
@emlowe
Copy link
Contributor

emlowe commented May 15, 2024

Approved - but can we take a look at what it would take to add in some tests that might add code coverage of those various error conditions in coin_funcs.py

wjblanke
wjblanke previously approved these changes May 16, 2024
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

Base automatically changed from catchup/long_lived_vault_from_main_bd3a638db10ee92a15f138ceaef06648c3c7b480 to long_lived/vault May 16, 2024 15:15
@Quexington Quexington dismissed stale reviews from wjblanke, emlowe, and AmineKhaldi May 16, 2024 15:15

The base branch was changed.

Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@Quexington Quexington merged commit 8f43e6c into long_lived/vault May 16, 2024
363 of 365 checks passed
@Quexington Quexington deleted the quex.port_chia_wallet_coins_to_tx_out branch May 16, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog vault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants