Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HB-6714] VersionCompareTest Fix for NuGet #210

Merged
merged 33 commits into from
Nov 14, 2023
Merged

[HB-6714] VersionCompareTest Fix for NuGet #210

merged 33 commits into from
Nov 14, 2023

Conversation

kushG
Copy link
Contributor

@kushG kushG commented Nov 14, 2023 •
edited
Loading

Title

HB-6714 VersionCompareTest fix for Nuget

Description

The earlier PR for this same ticket doesn't work when running on Nuget Demo project due to xmldocument using a namespace. Thi is now fixed in this PR

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)
  • Refactor / Maintenance (refactoring code to be cleaner/easier to maintain)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@SCastanedaMunoz SCastanedaMunoz requested review from a team, bwised, cb-jpadilla and SCastanedaMunoz and removed request for a team November 14, 2023 06:53
@SCastanedaMunoz SCastanedaMunoz changed the title [HB-6714] VersionCompareTest fix for Nuget [HB-6714] VersionCompareTest Fix for NuGet Nov 14, 2023
kushG and others added 19 commits November 13, 2023 23:20
@kushG
debug logs
8e5c8d3
@kushG
hardcoded strings into constants
da4dd36
@kushG
Merge remote-tracking branch 'origin/release/4.7.0' into HB-6714-nuge…
95ec2ed 
…t-package-path-fix

# Conflicts:
#	NuGet/Chartboost.CSharp.Mediation.Unity.4.7.0.nupkg
@helium-service
Updating Chartboost.CSharp.Mediation.Unity.nupkg
48c53dc
@kushG
removed remote source
9b1c41b
@helium-service
Updating Chartboost.CSharp.Mediation.Unity.nupkg
f582c13
@kushG
testing nuget pkg generation commit
cfde3c7
@kushG
Merge remote-tracking branch 'origin/HB-6714-nuget-package-path-fix' …
5e7c371 
…into HB-6714-nuget-package-path-fix
@kushG
syntax
2ac485a
@kushG
syntax
d3b4294
@kushG
Update status.yml
76face2 
Signed-off-by: kushG <[email protected]>
@kushG
Update status.yml
3c60b96 
Signed-off-by: kushG <[email protected]>
@kushG
Update status.yml
8f4979d 
Signed-off-by: kushG <[email protected]>
@kushG
Update status.yml
c6e2972 
Signed-off-by: kushG <[email protected]>
@kushG
Update status.yml
7e07a13 
Signed-off-by: kushG <[email protected]>
@kushG
Update status.yml
adfa037 
Signed-off-by: kushG <[email protected]>
@helium-service
Updating Chartboost.CSharp.Mediation.Unity.nupkg
a03ef03
@kushG
Delete .nuget_temp
b6d1bd0 
Signed-off-by: kushG <[email protected]>
@helium-service
Updating Chartboost.CSharp.Mediation.Unity.nupkg
cbf1dec
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited
Loading

Test Results

5 tests   5 ✔️  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit ccfe540.

♻️ This comment has been updated with latest results.

pleasesavemycat
pleasesavemycat approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@pleasesavemycat pleasesavemycat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SCastanedaMunoz SCastanedaMunoz merged commit a4c4675 into release/4.7.0 Nov 14, 2023
5 checks passed
@SCastanedaMunoz SCastanedaMunoz deleted the HB-6714-nuget-package-path-fix branch November 14, 2023 20:25
SCastanedaMunoz added a commit that referenced this pull request Nov 14, 2023
@SCastanedaMunoz @kushG @helium-service
Chartboost Mediation Unity SDK 4.7.0 into Main (#211)
c3548ea 
* [HB-6747] Passing Context when Getting Partner Consent (#206)

* [HB-6715] 4.7.0 `CHANGELOG.md` &  Documentation (#207)

* [HB-6524] Public NuGet Distribution (#205)

* [HB-6714] Compare SDK Version Against Versions in`package.json` and `.nuspec` (#208)

* version compare tests added

* Updating Chartboost.CSharp.Mediation.Unity.nupkg

---------

Co-authored-by: helium-service <[email protected]>

* [HB-6524] Update status.yml (#209)

* Update status.yml

Signed-off-by: kushG <[email protected]>

* [HB-6714] VersionCompareTest Fix for NuGet (#210)

* Update README.md

Signed-off-by: kushG <[email protected]>

---------

Signed-off-by: kushG <[email protected]>
Co-authored-by: kushG <[email protected]>
Co-authored-by: helium-service <[email protected]>
@kushG kushG mentioned this pull request Nov 14, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleasesavemycat pleasesavemycat pleasesavemycat approved these changes

@bwised bwised Awaiting requested review from bwised bwised was automatically assigned from ChartBoost/helium-unity

@cb-jpadilla cb-jpadilla Awaiting requested review from cb-jpadilla cb-jpadilla was automatically assigned from ChartBoost/helium-unity

@SCastanedaMunoz SCastanedaMunoz Awaiting requested review from SCastanedaMunoz SCastanedaMunoz was automatically assigned from ChartBoost/helium-unity

Assignees

@kushG kushG

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kushG @pleasesavemycat @SCastanedaMunoz @helium-service