Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HB-6524] Public NuGet Distribution #205

Merged

Conversation

kushG
Copy link
Contributor

@kushG kushG commented Nov 7, 2023

Title

HB-6524 Public Nuget Distribution

Description

Enables NuGet distribution of Chartboost Mediation Unity SDK

To accommodate Nuget distribution and UPM distribution together within this same repository the project structure is restructured as below

com.chartboost.mediation                 -- all the sdk code
com.chartboost.mediation.demo            -- all the code for demo
com.chartboost.mediation.demo.upm        -- unity project that integrates demo locally and sdk through NPM/UPM
com.chartboost.mediation.demo.nuget      -- unity project that integrates demo locally and sdk through Nuget/NugetForUnity

CI tasks run on both com.chartboost.mediation.demo.upm and com.chartboost.mediation.demo.nuget with the latter requiring a nuget packaging job as a prerequisite.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)
  • Refactor / Maintenance (refactoring code to be cleaner/easier to maintain)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kushG kushG changed the title Hb 6524 public nu get distribution of unity sdk [HB-6524] Public Nuget Distribution Nov 8, 2023
@kushG kushG self-assigned this Nov 8, 2023
@kushG kushG added the enhancement New feature or request label Nov 8, 2023
Copy link

github-actions bot commented Nov 8, 2023

Test Results

1 tests  ±0   1 ✔️ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 2636809. ± Comparison against base commit 8ac0b59.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@SCastanedaMunoz SCastanedaMunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at comments.

@SCastanedaMunoz SCastanedaMunoz changed the title [HB-6524] Public Nuget Distribution [HB-6524] Public NuGet Distribution Nov 13, 2023
Copy link
Collaborator

@SCastanedaMunoz SCastanedaMunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at comments

@SCastanedaMunoz SCastanedaMunoz merged commit 45194b6 into release/4.7.0 Nov 14, 2023
@SCastanedaMunoz SCastanedaMunoz deleted the HB-6524-public-nu-get-distribution-of-unity-sdk branch November 14, 2023 00:54
SCastanedaMunoz added a commit that referenced this pull request Nov 14, 2023
* [HB-6747] Passing Context when Getting Partner Consent (#206)

* [HB-6715] 4.7.0 `CHANGELOG.md` &  Documentation (#207)

* [HB-6524] Public NuGet Distribution (#205)

* [HB-6714] Compare SDK Version Against Versions in`package.json` and `.nuspec` (#208)

* version compare tests added

* Updating Chartboost.CSharp.Mediation.Unity.nupkg

---------

Co-authored-by: helium-service <[email protected]>

* [HB-6524] Update status.yml (#209)

* Update status.yml

Signed-off-by: kushG <[email protected]>

* [HB-6714] VersionCompareTest Fix for NuGet (#210)

* Update README.md

Signed-off-by: kushG <[email protected]>

---------

Signed-off-by: kushG <[email protected]>
Co-authored-by: kushG <[email protected]>
Co-authored-by: helium-service <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants