Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HB-6747] Passing Context when Getting Partner Consent in Android #206

Merged
merged 1 commit into from
Nov 8, 2023
Merged

[HB-6747] Passing Context when Getting Partner Consent in Android #206

merged 1 commit into from
Nov 8, 2023

Conversation

SCastanedaMunoz
Copy link
Collaborator

@SCastanedaMunoz SCastanedaMunoz commented Nov 8, 2023 •
edited by jira bot
Loading

Title

HB-6747 Passing Context when Getting Partner Consent in Android

Description

Passing context when getting partner consent in Android. This is required so it can values can be fetched before initialization.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)
  • Refactor / Maintenance (refactoring code to be cleaner/easier to maintain)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@SCastanedaMunoz SCastanedaMunoz added the bugfix Something has been fixed label Nov 8, 2023
@SCastanedaMunoz SCastanedaMunoz added this to the 4.7.0 milestone Nov 8, 2023
@SCastanedaMunoz SCastanedaMunoz requested a review from a team November 8, 2023 18:08
@SCastanedaMunoz SCastanedaMunoz self-assigned this Nov 8, 2023
@SCastanedaMunoz SCastanedaMunoz requested review from bwised, kushG and cb-jpadilla and removed request for a team November 8, 2023 18:08
pleasesavemycat
pleasesavemycat approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@pleasesavemycat pleasesavemycat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

Test Results

1 tests  ±0   1 ✔️ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit e8d45dc. ± Comparison against base commit 8ac0b59.

@SCastanedaMunoz SCastanedaMunoz merged commit 47781fa into release/4.7.0 Nov 8, 2023
3 checks passed
@SCastanedaMunoz SCastanedaMunoz deleted the HB-6747-mediation-unity-canary-add-per-partner-api-support-android-context branch November 8, 2023 20:13
SCastanedaMunoz added a commit that referenced this pull request Nov 14, 2023
@SCastanedaMunoz @kushG @helium-service
Chartboost Mediation Unity SDK 4.7.0 into Main (#211)
c3548ea 
* [HB-6747] Passing Context when Getting Partner Consent (#206)

* [HB-6715] 4.7.0 `CHANGELOG.md` &  Documentation (#207)

* [HB-6524] Public NuGet Distribution (#205)

* [HB-6714] Compare SDK Version Against Versions in`package.json` and `.nuspec` (#208)

* version compare tests added

* Updating Chartboost.CSharp.Mediation.Unity.nupkg

---------

Co-authored-by: helium-service <[email protected]>

* [HB-6524] Update status.yml (#209)

* Update status.yml

Signed-off-by: kushG <[email protected]>

* [HB-6714] VersionCompareTest Fix for NuGet (#210)

* Update README.md

Signed-off-by: kushG <[email protected]>

---------

Signed-off-by: kushG <[email protected]>
Co-authored-by: kushG <[email protected]>
Co-authored-by: helium-service <[email protected]>
@kushG kushG mentioned this pull request Nov 14, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb-jpadilla cb-jpadilla cb-jpadilla approved these changes

@pleasesavemycat pleasesavemycat pleasesavemycat approved these changes

@bichenwang bichenwang bichenwang approved these changes

@bwised bwised bwised approved these changes

@kushG kushG Awaiting requested review from kushG kushG was automatically assigned from ChartBoost/helium-unity

Assignees

@SCastanedaMunoz SCastanedaMunoz

Labels
bugfix Something has been fixed
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@SCastanedaMunoz @bwised @bichenwang @pleasesavemycat @cb-jpadilla