-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animated glTF with no skeletons defined crashes #8175
Comments
As noted in #8540:
|
A good minimal test case is in KhronosGroup/glTF-Sample-Models#243. |
Congratulations on closing the issue! I found these Cesium forum links in the comments above: https://groups.google.com/forum/#!topic/cesium-dev/EnrvvKk4qE4 If this issue affects any of these threads, please post a comment like the following:
|
Reported in this forum thread. Loading this glTF in CesiumJS produces the following crash:
char.glb.zip
This model is a valid glTF according to the Khronos validator and displays correctly in ThreeJS.
The problem seems to be that this model doesn't have any skeletons defined (which is optional according to the spec). So when it attempts to map joint names here:
https://github.com/AnalyticalGraphicsInc/cesium/blob/a355439140f37af904f47082e00612c90c6b7715/Source/Scene/Model.js#L2825-L2833
The returned
mappedJointNames
is an empty object, which causes it to push undefined nodes intoskinnedNode.joints
.The text was updated successfully, but these errors were encountered: