Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glTF 2.0 models cause crash when skin does not explicitly point to a skeleton. #8540

Closed
sanjeetsuhag opened this issue Jan 14, 2020 · 3 comments

Comments

@sanjeetsuhag
Copy link
Contributor

sanjeetsuhag commented Jan 14, 2020

glTF 2.0 allows for models with skins that don't directly refer to a skeleton. Cesium_Man.glb is validated by glTF Validator and is rendered in Babylon and Three.js, but causes an error in Cesium.

The issue lies in Source/Model.js where it's assumed that the skin will have a skeleton directly associated with it.

@emackey
Copy link
Contributor

emackey commented Jan 29, 2020

This is a fairly substantial discrepancy between Cesium and glTF's skinning specification. The spec explicitly says that the skeleton is optional, but Cesium treats it as required.

I'm by no means a skinning expert, but it appears very difficult with the current glTF-Blender-IO project to export any kind of skinned mesh from Blender and get it to load correctly in Cesium, even if the model validates correctly and loads into Babylon and ThreeJS without issue.

All of the "working in Cesium" skinned models that I know of appear to have come through COLLADA2GLTF, not Blender.

@OmarShehata
Copy link
Contributor

Is the same issue as #8175 ?

@emackey
Copy link
Contributor

emackey commented Jan 29, 2020

Oh yeah, I had deja-vu but I couldn't find that one, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants