Remove Cesium's use of glTF's optional skeleton property. #8756
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cesium was using the optional glTF property
skeleton
as a required property, and it looks like it was only using it to discover a list of joint nodes, which are required to be in the glTF. This may be the result of historical changes along the way from early versions of glTF, I'm not sure.In any case, this PR removes a pile of skeleton/forest searching logic and just uses the glTF joint list directly.
I tested CesiumMan of course, and a model of my own exported from Blender. Would be good to test this against a few more complex skinning examples to make sure nothing broke.
Fixes #8175.