Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error when user not found in ExperimentController #1692

Closed
wants to merge 4 commits into from

Conversation

KD1712
Copy link
Collaborator

@KD1712 KD1712 commented Jun 25, 2024

No description provided.

@KD1712 KD1712 linked an issue Jun 25, 2024 that may be closed by this pull request
@KD1712 KD1712 self-assigned this Jun 25, 2024
@RidhamShah
Copy link
Collaborator

RidhamShah commented Jun 26, 2024

These changes should be on all versions of ExperimentClientController.

@VivekFitkariwala
Copy link
Collaborator

VivekFitkariwala commented Jun 27, 2024

@bcb37 @danoswaltCL, At present we are fetching the user doc in each HTTP request of Experiment Client and that is redundant. In this PR is moving that in the middleware and the error will be thrown at the place where the document is fetched instead of the service which is incorrect.
We can have this middleware in the latest v5 version and not touch the service for backward compatibility.

cc - @KD1712

@danoswaltCL
Copy link
Collaborator

Another consideration is that this will break current non-client-library usage of the API, such as Livehint AI. They will need to begin sending this in the header for all calls.

@KD1712 KD1712 marked this pull request as draft July 1, 2024 11:12
@KD1712 KD1712 marked this pull request as ready for review July 1, 2024 13:25
@KD1712 KD1712 requested a review from RidhamShah July 1, 2024 13:25
@danoswaltCL danoswaltCL mentioned this pull request Jul 2, 2024
@danoswaltCL
Copy link
Collaborator

Let's wait on merging this in, see my comments in #1606

@danoswaltCL danoswaltCL marked this pull request as draft August 9, 2024 13:44
@danoswaltCL
Copy link
Collaborator

holding off on this one, going with existing 404 errors in the individual endpoints still for now

@danoswaltCL
Copy link
Collaborator

Needs to be only a part of the v6 controller. see: #1851 @ppratikcr7 @VivekFitkariwala

@ppratikcr7
Copy link
Collaborator

Closing this as its handled in a new PR with v6 client controller.

@ppratikcr7 ppratikcr7 closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

throw 404 if user not found in getKeys
6 participants