-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw error when user not found in ExperimentController #1692
Conversation
…Mocking middleware for testcase
These changes should be on all versions of ExperimentClientController. |
@bcb37 @danoswaltCL, At present we are fetching the user doc in each HTTP request of Experiment Client and that is redundant. In this PR is moving that in the middleware and the error will be thrown at the place where the document is fetched instead of the service which is incorrect. cc - @KD1712 |
Another consideration is that this will break current non-client-library usage of the API, such as Livehint AI. They will need to begin sending this in the header for all calls. |
Let's wait on merging this in, see my comments in #1606 |
holding off on this one, going with existing 404 errors in the individual endpoints still for now |
Needs to be only a part of the v6 controller. see: #1851 @ppratikcr7 @VivekFitkariwala |
Closing this as its handled in a new PR with v6 client controller. |
No description provided.