Throw error when user not found in ExperimentController

backend/packages/Upgrade/src/api/controllers/ExperimentClientController.v5.ts

@@ -36,6 +36,7 @@ import { MonitoredDecisionPointLog } from '../models/MonitoredDecisionPointLog';
 import { MarkExperimentValidatorv5 } from './validators/MarkExperimentValidator.v5';
 import { Log } from '../models/Log';
 import { ExperimentUserValidator } from './validators/ExperimentUserValidator';
+import { UserCheckMiddleware } from '../middlewares/UserCheckMiddleware';
 
 interface IMonitoredDecisionPoint {
   id: string;
@@ -97,6 +98,7 @@ interface IMonitoredDecisionPoint {
 
 @JsonController('/v5/')
 @UseBefore(ClientLibMiddleware)
+@UseBefore(UserCheckMiddleware)
 export class ExperimentClientController {
   constructor(
     public experimentService: ExperimentService,

backend/packages/Upgrade/src/api/middlewares/UserCheckMiddleware.ts

@@ -0,0 +1,36 @@
+import * as express from 'express';
+import { SettingService } from '../services/SettingService';
+import { SERVER_ERROR } from 'upgrade_types';
+import { AppRequest } from '../../types';
+import { Service } from 'typedi';
+import { ExperimentUserService } from '../services/ExperimentUserService';
+
+@Service()
+export class UserCheckMiddleware {
+  constructor(public settingService: SettingService, public experimentUserService: ExperimentUserService) {}
+
+  public async use(req: AppRequest, res: AppRequest, next: express.NextFunction): Promise<any> {
+    try {
+      const user_id = req.get('User-Id');
+      req.logger.child({ user_id });
+      req.logger.debug({ message: 'User Id is:', user_id });
+      console.log(user_id);
+      if (req.url !== '/api/init') {
+        const experimentUserDoc = await this.experimentUserService.getUserDoc(user_id, req.logger);
+
+        if (!experimentUserDoc) {
+          const error = new Error(`User not found: ${user_id}`);
+          (error as any).type = SERVER_ERROR.EXPERIMENT_USER_NOT_DEFINED;
+          (error as any).httpCode = 404;
+          req.logger.error(error);
+          return next(error);
+        }
+      }
+      // Continue to the next middleware/controller
+      next();
+    } catch (error) {
+      console.log(error);
+      return next(error);
+    }
+  }
+}

backend/packages/Upgrade/test/unit/controllers/ExperimentClientController.test.ts

@@ -8,12 +8,14 @@ import { ExperimentUserService } from '../../../src/api/services/ExperimentUserS
 import { FeatureFlagService } from '../../../src/api/services/FeatureFlagService';
 import { MetricService } from '../../../src/api/services/MetricService';
 import { ClientLibMiddleware } from '../../../src/api/middlewares/ClientLibMiddleware';
+import { UserCheckMiddleware } from '../../../src/api/middlewares/UserCheckMiddleware';
 import ExperimentServiceMock from './mocks/ExperimentServiceMock';
 import ExperimentAssignmentServiceMock from './mocks/ExperimentAssignmentServiceMock';
 import ExperimentUserServiceMock from './mocks/ExperimentUserServiceMock';
 import FeatureFlagServiceMock from './mocks/FeatureFlagServiceMock';
 import MetricServiceMock from './mocks/MetricServiceMock';
 import ClientLibMiddlewareMock from './mocks/ClientLibMiddlewareMock';
+import MockuserCheckMiddleware from './mocks/UserCheckMiddlewareMock';
 
 import { useContainer as classValidatorUseContainer } from 'class-validator';
 import { useContainer as ormUseContainer } from 'typeorm';
@@ -31,6 +33,7 @@ describe('Experiment Client Controller Testing', () => {
     Container.set(FeatureFlagService, new FeatureFlagServiceMock());
     Container.set(MetricService, new MetricServiceMock());
     Container.set(ClientLibMiddleware, new ClientLibMiddlewareMock());
+    Container.set(UserCheckMiddleware, new MockuserCheckMiddleware());
   });
 
   afterAll(() => {

backend/packages/Upgrade/test/unit/controllers/mocks/UserCheckMiddlewareMock.ts

@@ -0,0 +1,7 @@
+import * as express from 'express';
+
+export default class MockUserCheckMiddleware {
+  public async use(req: express.Request, res: express.Response, next: express.NextFunction): Promise<any> {
+    next();
+  }
+}

clientlibs/js/src/ApiService/ApiService.ts

@@ -82,6 +82,7 @@ export default class ApiService {
         'Session-Id': this.clientSessionId,
         'Client-source': IS_BROWSER ? 'browser' : 'node',
         URL: url,
+        'User-Id': this.userId,
       },
     };