Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create v6 client controller #1851

Closed
danoswaltCL opened this issue Aug 22, 2024 · 2 comments · Fixed by #1955 or #1988
Closed

create v6 client controller #1851

danoswaltCL opened this issue Aug 22, 2024 · 2 comments · Fixed by #1955 or #1988

Comments

@danoswaltCL
Copy link
Collaborator

danoswaltCL commented Aug 22, 2024

Release 6.0 will have some breaking changes, particularly the userId header. Currently those changes are to the v5 controller.

Changes needed:

  • In dev (6.0) the v5 controller needs to be converted to v6.
  • Client libraries should be pointed to v6.
  • We need the v5 controller to match what is on the release 5.2 branch (current production).
  • We need to remove user-ids from the request body for all client api's as it should be passed as a request header User-Id and attached in the request from the UserCheckMiddleware.

Dev note - add the version prefix to the swagger annotations. Make sure it's there in both remaining controllers so that both versions of each endpoint show up on the swagger web interface.

@danoswaltCL
Copy link
Collaborator Author

Will Qa

@danoswaltCL
Copy link
Collaborator Author

Bug referred to in #1657 , I moved that one back, it's related to this also though, when that is fixed I'll retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment