Send 400 bad request error for no user-id header in api request #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danoswaltCL
reviewed
Sep 26, 2024
| req.logger.debug({ message: 'User Id is:', user_id }); | ||
| if (!user_id) { | ||
| const error = new Error(`User-Id header not found.`); | ||
| (error as any).type = SERVER_ERROR.USER_NOT_FOUND; |
There was a problem hiding this comment.
well it's a bad request type, not really a user not found, the server has incomplete info to even try to find a user
There was a problem hiding this comment.
@danoswaltCL Yeah, I was also thinking to add a new ERROR type: MISSING_HEADER_USER_ID. But, got an input from our playpower team to reuse existing one's. I know this is for logged in user data not found from DB. I will update this if the above type looks good to you.
This was
linked to
issues
Sep 26, 2024
danoswaltCL
approved these changes
Sep 26, 2024
|
@danoswaltCL I was yet to push the commit with your requested change, just showed you that does this looks good. Will create another small PR for the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #1987