Wait to receive http response before delete modal close #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danoswaltCL
reviewed
Jun 14, 2024
frontend/projects/upgrade/src/app/core/feature-flags/feature-flags.service.ts
Outdated
Show resolved
Hide resolved
danoswaltCL
reviewed
Jun 14, 2024
...hboard/feature-flags/modals/delete-feature-flag-modal/delete-feature-flag-modal.component.ts
Outdated
Show resolved
Hide resolved
|
@Yagnik56 couple small things, otherwise looks great, I'm approving so you can merge when ready. |
danoswaltCL
previously approved these changes
Jun 14, 2024
danoswaltCL
approved these changes
Jun 17, 2024
danoswaltCL
deleted the
enhancement/wait-for-http-success-before-delete-modal-close
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add enhancement by disabling the delete button in the modal after it is clicked once and won't close the modal until the delete success message is received.