Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF fix Delete Modal: wait on http response before close #1648

Closed
danoswaltCL opened this issue Jun 12, 2024 · 2 comments · Fixed by #1651
Closed

FF fix Delete Modal: wait on http response before close #1648

danoswaltCL opened this issue Jun 12, 2024 · 2 comments · Fixed by #1651
Assignees
Labels

Comments

@danoswaltCL
Copy link
Collaborator

Modals should stay open after primary button click. All of our modals should follow this same UX pattern if there's an http call that is fired on primary click:

  • Disable the primary button so that the user doesn't double-click
  • Close on success response received.
  • OR if error, stay open and re-enable the button.
@danoswaltCL danoswaltCL added this to the Program Increment PI12 milestone Jun 12, 2024
@danoswaltCL danoswaltCL changed the title FF Delete Modal: wait on http response before FF fix Delete Modal: wait on http response before Jun 12, 2024
@danoswaltCL danoswaltCL changed the title FF fix Delete Modal: wait on http response before FF fix Delete Modal: wait on http response before close Jun 12, 2024
@Yagnik56 Yagnik56 self-assigned this Jun 13, 2024
@Yagnik56 Yagnik56 linked a pull request Jun 14, 2024 that will close this issue
@danoswaltCL danoswaltCL moved this to Code Review in UpGrade Project Jun 14, 2024
@ppratikcr7 ppratikcr7 moved this from Code Review to QA in UpGrade Project Jul 3, 2024
@amurphy-cl amurphy-cl assigned ppratikcr7 and unassigned Yagnik56 Sep 5, 2024
@ppratikcr7
Copy link
Collaborator

@Yagnik56 @zackcl The delete modal seems to be bit off in size as compared to other modals.
Image

@zackcl
Copy link
Collaborator

zackcl commented Sep 12, 2024

The width of the "Delete Feature Flag" modal is 480px in the original design in Figma. I think that should be correct in size.

Delete Feature Flag

@ppratikcr7 ppratikcr7 moved this from QA to Done in UpGrade Project Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants