resolved the review cmts

CarnegieLearningWeb · Jun 15, 2024 · 17b6000 · 17b6000
1 parent 62bcdef
commit 17b6000
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/frontend/projects/upgrade/src/app/core/feature-flags/feature-flags.service.ts b/frontend/projects/upgrade/src/app/core/feature-flags/feature-flags.service.ts
@@ -51,7 +51,7 @@ export class FeatureFlagsService {
   isSelectedFeatureFlagRemoved$ = this.store$.pipe(
     select(selectSelectedFeatureFlag),
     pairwise(),
-    filter(([prev, curr]) => prev !== null && prev !== undefined && (curr === null || curr === undefined))
+    filter(([prev, curr]) => prev && !curr)
   );
 
   selectedFlagOverviewDetails = this.store$.pipe(select(selectFeatureFlagOverviewDetails));

diff --git a/...ard/feature-flags/modals/delete-feature-flag-modal/delete-feature-flag-modal.component.ts b/...ard/feature-flags/modals/delete-feature-flag-modal/delete-feature-flag-modal.component.ts
@@ -62,15 +62,14 @@ export class DeleteFeatureFlagModalComponent {
   ) {}
 
   ngOnInit(): void {
-    this.listenForFeatureFlagListLengthChanges();
+    this.listenForSelectedFeatureFlagDeletion();
   }
 
   onInputChange(value: string): void {
     this.inputSubject.next(value);
   }
 
-  // Close the modal once the feature flag list length changes, as that indicates actual success
-  listenForFeatureFlagListLengthChanges(): void {
+  listenForSelectedFeatureFlagDeletion(): void {
     this.subscriptions = this.isSelectedFeatureFlagRemoved$.subscribe(() => this.closeModal());
   }