Feature/consistent alerts #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 0.3.0
hotfix logo
…mission status when logic is available
blankdots
approved these changes
Oct 7, 2020
| @@ -112,8 +82,10 @@ const WizardFooter = () => { | |||
| color="primary" | |||
| disabled={wizardStep < 1} | |||
| className={classes.footerButton} | |||
| // TODO: Implement save functionality | |||
There was a problem hiding this comment.
I think we can create an issue out of it for better tracking if there isn't one yet.
There was a problem hiding this comment.
NOTE: There needs to be a check if form / upload field values have changed from initial render.
This is addressed in #77
I think we can create an issue out of it for better tracking if there isn't one yet.
Yeah, this is a different issue since save functionality is out of scope of dialog alerts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created component for alert dialog. Component renders dialog content based on parent component location and alert type.
NOTE: When #77 is done, refactor alerts to be called only when form/upload has changed
Type of change
Changes Made
Testing