Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor app to follow good naming conventions #29

Closed
otahontas opened this issue Jul 21, 2020 · 0 comments · Fixed by #82
Closed

Refactor app to follow good naming conventions #29

otahontas opened this issue Jul 21, 2020 · 0 comments · Fixed by #82
Assignees
@saulipurhonen
Labels
enhancement New feature or request

Comments

@otahontas
Copy link
Contributor

Proposed solution

Check that component modules and components are CamelCase, create clear naming convention for component names: https://medium.com/@wittydeveloper/react-components-naming-convention-%EF%B8%8F-b50303551505

DoD (Definition of Done)

Project is clearly structured

Testing

peer to peer
@otahontas otahontas added the enhancement New feature or request label Jul 21, 2020
@saulipurhonen saulipurhonen linked a pull request Oct 7, 2020 that will close this issue
Feature/consistent alerts #81
Merged
2 tasks
@saulipurhonen saulipurhonen removed a link to a pull request Oct 7, 2020
Feature/consistent alerts #81
Merged
2 tasks
@saulipurhonen saulipurhonen self-assigned this Oct 7, 2020
@saulipurhonen saulipurhonen mentioned this issue Oct 8, 2020
Merged
2 tasks
@saulipurhonen saulipurhonen linked a pull request Oct 8, 2020 that will close this issue
Feature/naming conventions #82
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saulipurhonen saulipurhonen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/naming conventions CSCfi/metadata-submitter-frontend
3 participants
@blankdots @otahontas @saulipurhonen