Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make form closing alert to work more consistently #72

Closed
otahontas opened this issue Aug 13, 2020 · 1 comment · Fixed by #81
Closed

Make form closing alert to work more consistently #72

otahontas opened this issue Aug 13, 2020 · 1 comment · Fixed by #81
Assignees
Labels
enhancement New feature or request

Comments

@otahontas
Copy link
Contributor

otahontas commented Aug 13, 2020

Proposed solution

Currently form closing alert is rendered inside objectindex-component when user clicks for another submission type and is already on some form. This, however is not ideal solution since user can

  • click on next or previous, which dispatches another wizard step
  • click on cancel the whole form
  • click on save and exit

All of these should trigger some alert, so probably it's best to move alert handling to some centralized place.

Also alert content should work differently and have different content when user is in xml upload form or in add existing object -form.

DoD (Definition of Done)

Form closing works consistently. Reusable confirmation alert component is created and used in proper places.

@otahontas otahontas added the enhancement New feature or request label Aug 13, 2020
@saulipurhonen saulipurhonen self-assigned this Oct 5, 2020
@saulipurhonen
Copy link
Contributor

Merging this issue with previous alert issue #70
In both issues an alert component needs to be created and rendered with details depending on parent component.

@saulipurhonen saulipurhonen linked a pull request Oct 7, 2020 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants