fix #159 #160
Merged
fix #159 #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add initial CI setup to develop branch to trigger tests * Release preparation (CEA-COSMIC#146) * set fixed package versions * fixed discrepancy * test with v3.4.0 of matplotlib * lowered packages versions for python 3.6 support * fixed nibabel version * test github actions * test running examples * exclude example tests from nosetests * fixed script name * install pysap before running examples * PySAP installation updates (CEA-COSMIC#150) * updated conda env * updated environment * updated conda env * removed tensorflow from env * added pynfft to env * added Dockerfile * removed test lines from Dockerfile * Plug-in versions (CEA-COSMIC#149) * set plug-in and modopt versions for next release * updated pysap-mri version * Added new examples (CEA-COSMIC#152) Co-authored-by: chaithyagr <[email protected]> Co-authored-by: Samuel Farrens <[email protected]> * Release clean up (CEA-COSMIC#151) * updated readme * fixed typos * updated docker instructions * updated readthedocs to use conda env * updated nosetests to provide XML outputs (CEA-COSMIC#153) * updated nosetests to provide XML outputs * added Docker badge * Update README.rst * Update README.rst * Update ci-build.yml * Update setup.cfg * test adding pysphinxdoc Co-authored-by: Chaithya G R <[email protected]> Co-authored-by: chaithyagr <[email protected]>
* add initial CI setup to develop branch to trigger tests * Release preparation (CEA-COSMIC#146) * set fixed package versions * fixed discrepancy * test with v3.4.0 of matplotlib * lowered packages versions for python 3.6 support * fixed nibabel version * test github actions * test running examples * exclude example tests from nosetests * fixed script name * install pysap before running examples * PySAP installation updates (CEA-COSMIC#150) * updated conda env * updated environment * updated conda env * removed tensorflow from env * added pynfft to env * added Dockerfile * removed test lines from Dockerfile * Plug-in versions (CEA-COSMIC#149) * set plug-in and modopt versions for next release * updated pysap-mri version * Added new examples (CEA-COSMIC#152) Co-authored-by: chaithyagr <[email protected]> Co-authored-by: Samuel Farrens <[email protected]> * Release clean up (CEA-COSMIC#151) * updated readme * fixed typos * updated docker instructions * updated readthedocs to use conda env * updated nosetests to provide XML outputs (CEA-COSMIC#153) * updated nosetests to provide XML outputs * added Docker badge * Update README.rst * Update README.rst * Update ci-build.yml * Update setup.cfg * test adding pysphinxdoc * added CD build Co-authored-by: Chaithya G R <[email protected]> Co-authored-by: chaithyagr <[email protected]>
* add initial CI setup to develop branch to trigger tests * Release preparation (CEA-COSMIC#146) * set fixed package versions * fixed discrepancy * test with v3.4.0 of matplotlib * lowered packages versions for python 3.6 support * fixed nibabel version * test github actions * test running examples * exclude example tests from nosetests * fixed script name * install pysap before running examples * PySAP installation updates (CEA-COSMIC#150) * updated conda env * updated environment * updated conda env * removed tensorflow from env * added pynfft to env * added Dockerfile * removed test lines from Dockerfile * Plug-in versions (CEA-COSMIC#149) * set plug-in and modopt versions for next release * updated pysap-mri version * Added new examples (CEA-COSMIC#152) Co-authored-by: chaithyagr <[email protected]> Co-authored-by: Samuel Farrens <[email protected]> * Release clean up (CEA-COSMIC#151) * updated readme * fixed typos * updated docker instructions * updated readthedocs to use conda env * updated nosetests to provide XML outputs (CEA-COSMIC#153) * updated nosetests to provide XML outputs * added Docker badge * Update README.rst * Update README.rst * Update ci-build.yml * Update setup.cfg * test adding pysphinxdoc * added CD build * Update environment.yml Co-authored-by: Chaithya G R <[email protected]> Co-authored-by: chaithyagr <[email protected]>
|
Hi @paquiteau, thanks for the PR! I have approved the CI run and the proposed change seems fine to me, so if everything passes I should be able to merge this. |
Codecov Report
@@ Coverage Diff @@
## develop #160 +/- ##
========================================
Coverage 61.88% 61.88%
========================================
Files 30 30
Lines 1658 1658
========================================
Hits 1026 1026
Misses 632 632
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add std flags for c++14 (default is c++17 for gcc >=11)