Fix "No Number Contradiction" #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha! Excellent! Do you see the power of programming rules in terms of other rules? |
Bram28
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Right now there is a bug in the no number contradiction as pointed out in #32. The would incorrectly let you do a contradiction rule.
Additionally, the fill in black rule uses this contradiction rule. The fill in black rule had a bug as pointed out in #30.
New Behavior
The bug is no longer present as there is a check to verify all cells around the cell at question are black. This also ended up fixing the other bug.
Closes #32
Closes #30
If you test please try boards that are bugged and boards that work.