Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"No Number" not working #32

Closed
cjreed121 opened this issue Sep 17, 2021 · 1 comment
Closed

"No Number" not working #32

cjreed121 opened this issue Sep 17, 2021 · 1 comment
Labels
bug Something isn't working nurikabe

Comments

@cjreed121
Copy link
Collaborator

Current Behavior
There is a case where the contradiction No Number can incorrect be valid. An example is shown in the picture below.

nurikabe

This is assuming there is some white area that isn't a number surrounded by 4 black squares.

Expected Behavior
This should be invalid because there is no issue like that in the board.

Steps to reproduce

  1. Download and extract Error File.zip
  2. Open the file in Legup
  3. Go all the way to the right in the TreePanel and see the last rule
  4. You will see this is being marked as a valid rule when it should not be
@cjreed121 cjreed121 added the bug Something isn't working label Sep 17, 2021
@Gerzer Gerzer changed the title Nurikabe No Number not working No number not working Sep 18, 2021
@Gerzer Gerzer changed the title No number not working No Number not working Sep 18, 2021
@cjreed121 cjreed121 mentioned this issue Sep 26, 2021
Merged
@Gerzer Gerzer changed the title No Number not working "No Number" not working Sep 28, 2021
@Chase-Grajeda
Copy link
Collaborator

Closing case, bug fixed, solution merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working nurikabe
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Gerzer @cjreed121 @Chase-Grajeda