Fall 2021 (and a bit of Winter Break 2021-2022) Semester Master Push #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix "No Number Contradiction"
Confirmed fix, merging to dev
Modified some code to make the code easier to read and the logic easier to understand
Improved Readability
Rewrote CornerBasicBlackRule; still needs cleaning up
Removed unnecessary code and comments; still needs testing
As stated in a comment by Professor Bram, the "Unreachable White Region" rule has been renamed "Unreachables Are Black" to avoid confusion with the "Can't Reach White Cell" contradiction rule.
Prototype to solve the issue; hasn't been thoroughly tested. Also rolled back name change since that has deeper rooted issues.
Changed all usages of ordinal() to value() since the intended usage of ordinal() was meant for value()
Fixed minor Black Corner bug and adjusted debugging output
…te_region_bug Fixed Issue 46, Unreachable White Region Bug
Adjusted .gitignore to attempt to fix the merge conflict with dev
Removed unnecessary code and comments; still needs testing
Changed all usages of ordinal() to value() since the intended usage of ordinal() was meant for value()
Fixed minor Black Corner bug and adjusted debugging output
Adjusted .gitignore to attempt to fix the merge conflict with dev
…om/Bram-Hub/Legup into nurikabe_issue31_corners_black_out
Fix Issue 31: Corners Black Out Bug
Quick fix for Issue #57
charlestian23
changed the title
charlestian23
added
the
semester push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes in this push: