Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match_bool_prefix #187 #69

Merged
merged 31 commits into from
Jun 6, 2022

Conversation

forestmvey
Copy link

@forestmvey forestmvey commented Jun 6, 2022

Description

Add match_bool_prefix SQL and PPL Syntax with optional parameters.

Issues Resolved

187

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

MaxKsyunz and others added 30 commits May 17, 2022 15:16
Required renaming analyzeSyntax to parse.

Signed-off-by: MaxKsyunz <[email protected]>
Added base class that is commont to match_query and match_bool_prefix and others.

Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Thus completing update from upstream/main.

Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: forestmvey <[email protected]>
Signed-off-by: forestmvey <[email protected]>
IntelliJ's Cleanup considered these casts "redundant" and removed them.

This caused compilation to fail.

Signed-off-by: MaxKsyunz <[email protected]>
match_bool_prefix merge dev branch 2#187
@forestmvey forestmvey requested a review from a team June 6, 2022 17:30
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #69 (9b0eeb9) into integ-match_bool_prefix-#187 (26058b8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                       Coverage Diff                       @@
##             integ-match_bool_prefix-#187      #69   +/-   ##
===============================================================
  Coverage                           97.66%   97.67%           
- Complexity                           2743     2754   +11     
===============================================================
  Files                                 268      269    +1     
  Lines                                6772     6789   +17     
  Branches                              435      435           
===============================================================
+ Hits                                 6614     6631   +17     
  Misses                                157      157           
  Partials                                1        1           
Flag Coverage Δ
sql-engine 97.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...arch/storage/script/filter/FilterQueryBuilder.java 100.00% <ø> (ø)
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <100.00%> (ø)
...h/sql/expression/function/OpenSearchFunctions.java 100.00% <100.00%> (ø)
.../filter/lucene/relevance/MatchBoolPrefixQuery.java 100.00% <100.00%> (ø)
...c/main/java/org/opensearch/sql/ppl/PPLService.java 100.00% <100.00%> (ø)
.../org/opensearch/sql/ppl/antlr/PPLSyntaxParser.java 100.00% <100.00%> (ø)
.../org/opensearch/sql/sql/antlr/SQLSyntaxParser.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26058b8...9b0eeb9. Read the comment docs.

@forestmvey forestmvey merged commit 0bcc123 into integ-match_bool_prefix-#187 Jun 6, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the dev-match_bool_prefix-#187 branch January 12, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants