match_bool_prefix merge dev branch 2#187 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: forestmvey <[email protected]>
Signed-off-by: forestmvey <[email protected]>
Signed-off-by: forestmvey <[email protected]>
Signed-off-by: forestmvey <[email protected]>
Signed-off-by: forestmvey <[email protected]>
forestmvey
force-pushed
the
dev-match_bool_prefix-2#187
branch
from
99779b1 to
5798b06
Compare
Signed-off-by: forestmvey <[email protected]>
Signed-off-by: forestmvey <[email protected]>
Signed-off-by: forestmvey <[email protected]>
MaxKsyunz
approved these changes
Jun 1, 2022
Codecov Report
@@ Coverage Diff @@
## dev-match_bool_prefix-#187 #64 +/- ##
=============================================================
Coverage 97.67% 97.67%
- Complexity 2748 2754 +6
=============================================================
Files 269 269
Lines 6784 6789 +5
Branches 435 435
=============================================================
+ Hits 6626 6631 +5
Misses 157 157
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| } | ||
|
|
||
| @Test | ||
| public void testFuzziness() throws IOException { |
There was a problem hiding this comment.
Please, rename. The fuzziness parameter could be tested in different functions.
There was a problem hiding this comment.
MitchellGale
approved these changes
Jun 1, 2022
acarbonetto
approved these changes
Jun 1, 2022
Signed-off-by: forestmvey <[email protected]>
Signed-off-by: forestmvey <[email protected]>
Yury-Fridlyand
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added optional parameters to sql with unit tests, integration tests, and parser tests.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.