-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
match_bool_prefix Add PPL Syntax #67
match_bool_prefix Add PPL Syntax #67
Conversation
Signed-off-by: forestmvey <[email protected]>
Codecov Report
@@ Coverage Diff @@
## dev-match_bool_prefix-#187 #67 +/- ##
=============================================================
Coverage 97.67% 97.67%
Complexity 2754 2754
=============================================================
Files 269 269
Lines 6789 6789
Branches 435 435
=============================================================
Hits 6631 6631
Misses 157 157
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
JSONObject result = | ||
executeQuery( | ||
String.format( | ||
"source=%s | where match_bool_prefix(phrase, 'quick') | fields phrase", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we change this test to match_bool_prefix(phrase, 'qui')
and it'll still work? Isn't the last term supposed to be a prefix rather than the full word?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See b6252762cb8b31e990518bf62b6bacc0431ee10c for this fix.
JSONObject result = | ||
executeQuery( | ||
String.format( | ||
"source=%s | where match_bool_prefix(phrase, '2 test', minimum_should_match=1, fuzziness=2) | fields phrase", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, shouldn't this be something like match_bool_prefix(phrase, '2 tes'
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See b6252762cb8b31e990518bf62b6bacc0431ee10c for this fix.
…function Signed-off-by: forestmvey <[email protected]>
Description
Add PPL syntax for match_bool_prefix.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.