Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match_bool_prefix Add PPL Syntax #67

Merged

Conversation

forestmvey
Copy link

Description

Add PPL syntax for match_bool_prefix.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@forestmvey forestmvey requested a review from a team June 3, 2022 22:23
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #67 (b625276) into dev-match_bool_prefix-#187 (3f6ac10) will not change coverage.
The diff coverage is n/a.

@@                      Coverage Diff                      @@
##             dev-match_bool_prefix-#187      #67   +/-   ##
=============================================================
  Coverage                         97.67%   97.67%           
  Complexity                         2754     2754           
=============================================================
  Files                               269      269           
  Lines                              6789     6789           
  Branches                            435      435           
=============================================================
  Hits                               6631     6631           
  Misses                              157      157           
  Partials                              1        1           
Flag Coverage Δ
sql-engine 97.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6ac10...b625276. Read the comment docs.

JSONObject result =
executeQuery(
String.format(
"source=%s | where match_bool_prefix(phrase, 'quick') | fields phrase",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change this test to match_bool_prefix(phrase, 'qui') and it'll still work? Isn't the last term supposed to be a prefix rather than the full word?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSONObject result =
executeQuery(
String.format(
"source=%s | where match_bool_prefix(phrase, '2 test', minimum_should_match=1, fuzziness=2) | fields phrase",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, shouldn't this be something like match_bool_prefix(phrase, '2 tes'?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forestmvey forestmvey merged commit 9b0eeb9 into dev-match_bool_prefix-#187 Jun 6, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the dev-match_bool_prefix-ppl#187 branch January 12, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants