Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Filter by DfTxType in AccountRPCs #332

Closed
wants to merge 17 commits into from
Closed

Add Filter by DfTxType in AccountRPCs #332

wants to merge 17 commits into from

Conversation

siradji
Copy link
Contributor

@siradji siradji commented Jun 2, 2021

What kind of PR is this?:

/kind fix

What this PR does / why we need it:

Implemented TxType enum to fix #252

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

@siradji siradji self-assigned this Jun 2, 2021
@siradji siradji requested a review from thedoublejay as a code owner June 2, 2021 07:41
@codeclimate
Copy link

codeclimate bot commented Jun 2, 2021 •
edited
Loading

Code Climate has analyzed commit f85b6d7 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Jun 2, 2021 •
edited
Loading

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: f85b6d7

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60b902eb0953c100084ef6a5

😎 Browse the preview: https://deploy-preview-332--jellyfish-defi.netlify.app

@github-actions
Copy link

github-actions bot commented Jun 2, 2021 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 19.9 KB (+0.01% 🔺) 398 ms (+0.01% 🔺) 163 ms (-10.44% 🔽) 561 ms

@codecov
Copy link

codecov bot commented Jun 2, 2021 •
edited
Loading

Codecov Report

Merging #332 (fb52da2) into main (0629109) will not change coverage.
The diff coverage is n/a.

❗ Current head fb52da2 differs from pull request most recent head f85b6d7. Consider uploading reports for the commit f85b6d7 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   97.05%   97.05%           
=======================================
  Files          91       91           
  Lines        2577     2577           
  Branches      327      327           
=======================================
  Hits         2501     2501           
  Misses         76       76
Impacted Files Coverage Δ
...ackages/jellyfish-api-core/src/category/account.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0629109...f85b6d7. Read the comment docs.

@siradji siradji requested a review from canonbrother June 2, 2021 11:37
@fuxingloh fuxingloh changed the title Filter by TxType # Filter by TxType Jun 2, 2021
ivan-zynesis
ivan-zynesis requested changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@ivan-zynesis ivan-zynesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to name it specifically apply for custom tx only

website/docs/jellyfish/api/account.md Outdated Show resolved Hide resolved
fuxingloh
fuxingloh previously approved these changes Jun 3, 2021
View reviewed changes
@fuxingloh fuxingloh self-requested a review June 3, 2021 01:36
@fuxingloh fuxingloh changed the title Filter by TxType Filter by DfTxType Jun 3, 2021
@fuxingloh fuxingloh changed the title Filter by DfTxType Add Filter by DfTxType in AccountRPCs Jun 3, 2021
@fuxingloh fuxingloh marked this pull request as draft June 3, 2021 12:17
@siradji siradji requested a review from ivan-zynesis June 3, 2021 15:51
siradji and others added 6 commits June 3, 2021 16:57
@siradji
Filter by TxType
f3f823c
@siradji
Minor fixes
f813e09
@siradji
Minor fixes
0531a4b
@fuxingloh @siradji
Update packages/jellyfish-api-core/src/category/account.ts
c21f297
@siradji
Implemented suggessions from code review
a593d59
@siradji
Merge remote-tracking branch 'refs/remotes/origin/siradji/txtType-lis…
f85b6d7 
…taccounthistory'

Conflicts:
	packages/jellyfish-api-core/__tests__/category/account/listAccountHistory.test.ts
	packages/jellyfish-api-core/src/category/account.ts
	website/docs/jellyfish/api/account.md
@siradji siradji closed this Jun 3, 2021
@siradji siradji deleted the siradji/txtType-listaccounthistory branch June 3, 2021 16:30
eli-lim pushed a commit that referenced this pull request Mar 27, 2022
@fuxingloh
added a/b symbol for PoolPairData (#332)
dc84e03
canonbrother pushed a commit that referenced this pull request Jun 1, 2022
@fuxingloh
added a/b symbol for PoolPairData (#332)
739f9f9
canonbrother pushed a commit that referenced this pull request Jun 1, 2022
@fuxingloh
added a/b symbol for PoolPairData (#332)
103ddd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingyi2811 jingyi2811 Awaiting requested review from jingyi2811

@thedoublejay thedoublejay Awaiting requested review from thedoublejay

@canonbrother canonbrother Awaiting requested review from canonbrother canonbrother is a code owner

@fuxingloh fuxingloh Awaiting requested review from fuxingloh

@ivan-zynesis ivan-zynesis Awaiting requested review from ivan-zynesis ivan-zynesis is a code owner

Assignees

@siradji siradji

Labels
area/workflow kind/fix Fix a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter txtype Parameter of listAccountHistory() doesn´t seem to filter AccountHistory
7 participants
@siradji @fuxingloh @canonbrother @ivan-zynesis @defichain-bot @jingyi2811 @aikchun