Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mintTokens rpc #290

Merged
merged 10 commits into from
Jun 3, 2021
Merged

Add mintTokens rpc #290

merged 10 commits into from
Jun 3, 2021

Conversation

jingyi2811
Copy link
Contributor

@jingyi2811 jingyi2811 commented May 25, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Add mintTokens rpc

Which issue(s) does this PR fixes?:

Fixes part of #48

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented May 25, 2021

Code Climate has analyzed commit b682ac7 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented May 25, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: b682ac7

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60b7801580da6e0007119fa8

😎 Browse the preview: https://deploy-preview-290--jellyfish-defi.netlify.app

@github-actions
Copy link

github-actions bot commented May 25, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 19.63 KB (+0.14% 🔺) 393 ms (+0.14% 🔺) 153 ms (-5.42% 🔽) 545 ms

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #290 (b682ac7) into main (9d311db) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #290   +/-   ##
=======================================
  Coverage   97.04%   97.05%           
=======================================
  Files          91       91           
  Lines        2507     2579   +72     
  Branches      318      328   +10     
=======================================
+ Hits         2433     2503   +70     
- Misses         74       76    +2     
Impacted Files Coverage Δ
packages/jellyfish-api-core/src/category/token.ts 100.00% <100.00%> (ø)
...ainers/src/chains/reg_test_container/masternode.ts 94.44% <0.00%> (-3.71%) ⬇️
...jellyfish-transaction/src/script/defi/dftx_pool.ts 100.00% <0.00%> (ø)
...h-transaction-builder/src/txn/txn_builder_error.ts 100.00% <0.00%> (ø)
...transaction-builder/src/txn/txn_builder_oracles.ts 100.00% <0.00%> (ø)
...ellyfish-transaction/src/buffer/buffer_composer.ts 99.50% <0.00%> (+0.03%) ⬆️
...ages/jellyfish-transaction/src/script/defi/dftx.ts 97.43% <0.00%> (+0.13%) ⬆️
...ckages/jellyfish-transaction/src/script/mapping.ts 96.66% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d311db...b682ac7. Read the comment docs.

# Conflicts:
#	packages/jellyfish-api-core/__tests__/category/token.test.ts
@jingyi2811 jingyi2811 marked this pull request as ready for review May 31, 2021 12:33
@jingyi2811 jingyi2811 marked this pull request as draft May 31, 2021 13:02
@jingyi2811 jingyi2811 marked this pull request as ready for review May 31, 2021 13:17
canonbrother
canonbrother previously approved these changes Jun 1, 2021
@fuxingloh fuxingloh merged commit 2f3ab75 into main Jun 3, 2021
@fuxingloh fuxingloh deleted the jimmy/minttokens branch June 3, 2021 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants