Consortium DfTxs (Custom Light Transaction) #1823
Assignees
Labels
area/packages
kind/feature
New feature request
priority/important-soon
Will be important soon
triage/accepted
Triage has been accepted
Comments
github-actions
bot
added
triage/accepted
|
/assign @infinia-yzl to manage and assign to BR_Hydra, closely related to upcoming work for bridge and cde. |
3 tasks
fuxingloh
pushed a commit
that referenced
this issue
Jan 16, 2023
<!-- Thanks for sending a pull request! --> #### What this PR does / why we need it: - [x] Add CTokenBurn in jellyfish transaction to be used in bridge - [x] Create txn builder for burntoken - [x] Address PR feedbacks #### Which issue(s) does this PR fixes?: <!-- (Optional) Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes #1823 #### Additional comments?: - Big thanks to @canonbrother for the help! 🙏 💪 Co-authored-by: Isaac Yong <[email protected]>
3 tasks
fuxingloh
pushed a commit
that referenced
this issue
Jan 31, 2023
…2004) <!-- Thanks for sending a pull request! --> #### What this PR does / why we need it: - [x] Add dftx for minting token - [x] Add txn builder for minting token - [x] Add e2e tests #### Which issue(s) does this PR fixes?: <!-- (Optional) Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes #1823 #### Additional comments?: - One concern that requires more deep diving in the code is [this](https://github.com/JellyfishSDK/jellyfish/pull/2004/files#diff-cd9b0bc9a5bc8cb12469fe1dddc7fff62cecfe543b8a6946c7bff87492dc3dc0R26) - `to` is not optional in this PR but it is in `ain`. Need to deep dive on how to do it properly with composer. This parameter (`to`) being required still caters for the need of Bridge API. Relevant Issue on bridge: https://github.com/WavesHQ/bridge/issues/185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Similar to #108, implementations of Consortium Custom DfTx.
// TODOin
All CustomTX has a starting signature of
DfTxin utf8 or0x44665478. It is as it is, don't need to convert from BE to LE.They are structured as a
VarUInt+ [OP_RETURN+DfTx+TYPES[CxTxType]+ ...]VarUInt+6a+44665478+ Type + .../triage accepted
/kind feature
/area packages
/priority important-soon
Refer to #108 for a detailed implementation guide; please edit and fill in the issue.
The text was updated successfully, but these errors were encountered: