Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeFi CustomTx scripting #108

Closed
17 tasks done
fuxingloh opened this issue Apr 12, 2021 · 8 comments
Closed
17 tasks done

DeFi CustomTx scripting #108

fuxingloh opened this issue Apr 12, 2021 · 8 comments
Assignees
Labels
kind/feature New feature request priority/important-soon Will be important soon triage/accepted Triage has been accepted

Comments

@fuxingloh
Copy link
Contributor

fuxingloh commented Apr 12, 2021

This tracks all the DeFi scripting (AKA CustomTx) that is to be implemented in jellyfish-transaction.

packages/jellyfish-transaction/src/script/defi/*

All CustomTX has a starting signature of DfTx in utf8 or 0x44665478. It is as it is, don't need to convert from BE to LE.

They are structured as a

  1. VarUInt + [OP_RETURN + DfTx + TYPES[CxTxType] + ...]
  2. VarUInt + 6a + 44665478 + Type + ...

CustomTx

It's a char, UTF8 -> HEX

@fuxingloh fuxingloh added this to the Jellyfish Wallet milestone Apr 12, 2021
@defichain-bot defichain-bot added the needs/triage Waiting for triage to be accepted label Apr 12, 2021
@defichain-bot
Copy link
Contributor

@fuxingloh: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@fuxingloh fuxingloh added the triage/accepted Triage has been accepted label Apr 12, 2021
@defichain-bot defichain-bot removed the needs/triage Waiting for triage to be accepted label Apr 12, 2021
@fuxingloh fuxingloh added the priority/important-soon Will be important soon label Apr 12, 2021
@fuxingloh

This comment has been minimized.

@fuxingloh
Copy link
Contributor Author

Check out #146 it's a good example on how to create DfTx

@ivan-zynesis
Copy link
Contributor

Start working on.

  • utxosToAccount: 'U'
  • accountToUtxos: 'b'
  • accountToAccount: 'B'
  • anyAccountsToAccounts: 'a'

Hopefully can get clear mental picture and estimate time needed soon.

@canonbrother
Copy link
Contributor

canonbrother commented May 12, 2021

Working on createToken: 'T' (missed update)

@canonbrother
Copy link
Contributor

canonbrother commented May 12, 2021

Working on createPoolPair: 'p'

@ivan-zynesis
Copy link
Contributor

ivan-zynesis commented May 24, 2021

Start working on: AutoAuthPrep - 'A'

@fuxingloh
Copy link
Contributor Author

/close as all is approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request priority/important-soon Will be important soon triage/accepted Triage has been accepted
Projects
None yet
Development

No branches or pull requests

5 participants