Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Chain Governance DfTxs (Custom Light Transaction) #1822

Closed
Tracked by #1817
fuxingloh opened this issue Oct 18, 2022 · 1 comment · Fixed by #1851
Closed
Tracked by #1817

On Chain Governance DfTxs (Custom Light Transaction) #1822

fuxingloh opened this issue Oct 18, 2022 · 1 comment · Fixed by #1851
Assignees
@infinia-yzl @delphk
Labels
area/packages kind/feature New feature request priority/important-soon Will be important soon triage/accepted Triage has been accepted

Comments

@fuxingloh
Copy link
Contributor

fuxingloh commented Oct 18, 2022 •
edited
Loading

Similar to #108, implementations of On Chain Governance Custom DfTx.

 // TODO

in

packages/jellyfish-transaction/src/script/defi/*

All CustomTX has a starting signature of DfTx in utf8 or 0x44665478. It is as it is, don't need to convert from BE to LE.

They are structured as a

  1. VarUInt + [OP_RETURN + DfTx + TYPES[CxTxType] + ...]
  2. VarUInt + 6a + 44665478 + Type + ...

/triage accepted
/kind feature
/area packages
/priority important-soon

Refer to #108 for a detailed implementation guide; please edit and fill in the issue.
I believe this is already partially completed; if that's the case, we should update the tests to reflect that.
@fuxingloh fuxingloh mentioned this issue Oct 18, 2022
Closed
5 tasks
@github-actions github-actions bot added triage/accepted Triage has been accepted kind/feature New feature request area/packages priority/important-soon Will be important soon labels Oct 18, 2022
@fuxingloh
Copy link
Contributor Author

Unassigned #1823 (comment)

/assign @imkven @infinia-yzl this topic instead

@delphk delphk mentioned this issue Nov 7, 2022
Merged
@infinia-yzl infinia-yzl assigned delphk and unassigned imkven Nov 14, 2022
fuxingloh pushed a commit that referenced this issue Dec 2, 2022
@delphk @infinia-yzl
feat(jellyfish-transaction): add on-chain governance dftx (#1851)
7ac010b 
<!--  Thanks for sending a pull request! -->

#### What this PR does / why we need it:
/kind feature

#### Which issue(s) does this PR fixes?:
<!--
(Optional) Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
Fixes #1822 and fixes #1890 

#### Additional comments?:

Co-authored-by: Isaac Yong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@infinia-yzl infinia-yzl

@delphk delphk

Labels
area/packages kind/feature New feature request priority/important-soon Will be important soon triage/accepted Triage has been accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(jellyfish-transaction): add on-chain governance dftx BirthdayResearch/jellyfishsdk
4 participants
@imkven @infinia-yzl @fuxingloh @delphk