Make ApplyFiltering, ApplySorting and ApplyPagination protected virtu… #144
Conversation
|
Mhm you're right. Didn't think about that point in this case. But I think we need to open Sieve. When I take a look at some of our projects, which are based on Sieve, we had to implement some ugly workarounds, too. Pros and cons... |
|
Tell me about it :) I had to write a veeery fat builder for multiple entities including using a runtime compiler.. |
There was a problem hiding this comment.
Hm I'm happy with this change, however my general outlook is to implement any extensions ourselves rather than declaring a "wontfix" and leaving developers to manually override these methods.
Eg. the skip/top request in #138 - rather than make Sieve more extensible through this PR, we can just implement skip/top as a core part of Sieve.
The reality is there is not an infinite amount of ways to sort/filter/paginate/select, there is only a few practical ways - so it might be worth us directly implementing them to keep quality up and uphold the "out of the box" claim in the readme! I'd be interesting in hearing about workarounds you guys have had to make as that's exactly what we should tackle :)
|
I like the idea to put as much as possible to Sieve. Maybe we should think about splitting the SieveProcessor (which does most oft the work now) into smaller pieces to tackle it. But maybe we should start a discussion about "How to make Sieve more flexible" ;-) But I think that Sieve should still be as extensible as possible. There will be edge cases which we won't support by our core implementation. |
|
I'm fully on board with splitting up the SieveProcessor - perhaps by separating the sorting, filtering, and pagination bits entirely. I think I saw an issue for it a while back but can't find it now I think we should list up some scenarios that Sieve can't handle right now and use that to decide next steps, eg. #146 |
* Setup release 2.5.0 with automated build and pre-releases * #80 added support for escaping pipe control characters (#113) * #80 added support for escaping comma and pipe control characters * Update SieveModel.cs Fix build. Accidentally broken by resolving conflicts. * Migrate UnitTests to xUnit Co-authored-by: Clayton Andersen <[email protected]> Co-authored-by: ITDancer13 <[email protected]> Co-authored-by: ITDancer139 <[email protected]> * SieveProcessor.Options made protected property (#134) Mapper assignment in constructor is moved to a null-coalescing member pair (a field and a property) "IncludeScopes" switch is removed from appSettings.{env}.json files * Revert to _mapper assignment in constructor. (#140) * reverting fix (#142) * Revert to _mapper assignment in constructor. * reverting fix * pass filter values as parameters (#112) make GetClosureOverConstant really work * Make ApplyFiltering, ApplySorting and ApplyPagination protected virtual #139 (#144) * stop excluding null values when filtering using notEqual (#114) * stop excluding null values when filtering using notEqual * add IgnoreNullsOnNotEqual config field, to enable/disable the new feature Co-authored-by: AnasZakarneh <[email protected]> Co-authored-by: Clayton Andersen <[email protected]> Co-authored-by: Clayton Andersen <[email protected]> Co-authored-by: ITDancer139 <[email protected]> Co-authored-by: Hasan Manzak <[email protected]> Co-authored-by: alicak <[email protected]> Co-authored-by: AnasZakarneh <[email protected]> Co-authored-by: AnasZakarneh <[email protected]>
Make ApplyFiltering, ApplySorting and ApplyPagination protected virtual.
Closes #139