#80 added support for escaping pipe control characters #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have the same issue on our side. Thanks for your attempt to fix it 👍 |
ITDancer13
approved these changes
Mar 16, 2021
nasirk49
approved these changes
Mar 16, 2021
|
@claytonandersen Could you resolve the conflicts? I think there were other changes before this pr yet to be merged. |
|
@claytonandersen Thanks for your contribution. I've already fixed the comma issue when I merged the changes from my fork. Can you please rebase your branch and change the target to |
Fix build. Accidentally broken by resolving conflicts.
ITDancer13
changed the title
hasanmanzak
approved these changes
May 15, 2021
|
Hey, looks like this was done, sorry I didn't get back to it until today. The merge looks good though. Thanks @ITDancer13 @hasanmanzak ! |
ITDancer13
added a commit
that referenced
this pull request
Aug 29, 2021
* Setup release 2.5.0 with automated build and pre-releases * #80 added support for escaping pipe control characters (#113) * #80 added support for escaping comma and pipe control characters * Update SieveModel.cs Fix build. Accidentally broken by resolving conflicts. * Migrate UnitTests to xUnit Co-authored-by: Clayton Andersen <[email protected]> Co-authored-by: ITDancer13 <[email protected]> Co-authored-by: ITDancer139 <[email protected]> * SieveProcessor.Options made protected property (#134) Mapper assignment in constructor is moved to a null-coalescing member pair (a field and a property) "IncludeScopes" switch is removed from appSettings.{env}.json files * Revert to _mapper assignment in constructor. (#140) * reverting fix (#142) * Revert to _mapper assignment in constructor. * reverting fix * pass filter values as parameters (#112) make GetClosureOverConstant really work * Make ApplyFiltering, ApplySorting and ApplyPagination protected virtual #139 (#144) * stop excluding null values when filtering using notEqual (#114) * stop excluding null values when filtering using notEqual * add IgnoreNullsOnNotEqual config field, to enable/disable the new feature Co-authored-by: AnasZakarneh <[email protected]> Co-authored-by: Clayton Andersen <[email protected]> Co-authored-by: Clayton Andersen <[email protected]> Co-authored-by: ITDancer139 <[email protected]> Co-authored-by: Hasan Manzak <[email protected]> Co-authored-by: alicak <[email protected]> Co-authored-by: AnasZakarneh <[email protected]> Co-authored-by: AnasZakarneh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an escaped comma or pipe in a value filter causes Sieve to send the escape character in the filter expression. This PR removes the escape character when the filter is built.