Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ApplyFiltering, ApplySorting and ApplyPagination protected virtual #139

Closed
ITDancer13 opened this issue May 16, 2021 · 0 comments · Fixed by #144
Closed

Make ApplyFiltering, ApplySorting and ApplyPagination protected virtual #139

ITDancer13 opened this issue May 16, 2021 · 0 comments · Fixed by #144
Labels
enhancement New feature or request
Milestone
v2.5

Comments

@ITDancer13
Copy link
Collaborator

Quick win as suggested in #138: "I think a quick fix to make this easier would be to make the ApplyPagination, ApplyFiltering, ApplySorting methods protected and virtual. This would let users inherit from SieveProcessor and only have to override the methods they care about changing."
@ITDancer13 ITDancer13 added the enhancement New feature or request label May 16, 2021
@ITDancer13 ITDancer13 added this to the v2.5 milestone May 16, 2021
ITDancer13 added a commit that referenced this issue May 16, 2021
@ITDancer13
Make ApplyFiltering, ApplySorting and ApplyPagination protected virtual
73e67d3 
#139
ITDancer13 added a commit that referenced this issue May 16, 2021
@ITDancer13
Make ApplyFiltering, ApplySorting and ApplyPagination protected virtual
3f661e9 
#139
@ITDancer13 ITDancer13 mentioned this issue May 16, 2021
Merged
@ITDancer13 ITDancer13 linked a pull request May 17, 2021 that will close this issue
Make ApplyFiltering, ApplySorting and ApplyPagination protected virtu… #144
Merged
ITDancer13 added a commit that referenced this issue May 17, 2021
@ITDancer13
Make ApplyFiltering, ApplySorting and ApplyPagination protected virtual
7542ec0 
#139 (#144)
ITDancer13 added a commit that referenced this issue Aug 29, 2021
@ITDancer13 @claytonandersen
@r365-claytonandersen @hasanmanzak @alicak @AnasZakarneh
Release Sieve 2.5.0 (#151)
e83d213 
* Setup release 2.5.0 with automated build and pre-releases

* #80 added support for escaping pipe control characters (#113)

* #80 added support for escaping comma and pipe control characters

* Update SieveModel.cs

Fix build. Accidentally broken by resolving conflicts.

* Migrate UnitTests to xUnit

Co-authored-by: Clayton Andersen <[email protected]>
Co-authored-by: ITDancer13 <[email protected]>
Co-authored-by: ITDancer139 <[email protected]>

* SieveProcessor.Options made protected property (#134)

Mapper assignment in constructor is moved to a null-coalescing member pair (a field and a property)
"IncludeScopes" switch is removed from appSettings.{env}.json files

* Revert to _mapper assignment in constructor. (#140)

* reverting fix (#142)

* Revert to _mapper assignment in constructor.

* reverting fix

* pass filter values as parameters (#112)

make GetClosureOverConstant really work

* Make ApplyFiltering, ApplySorting and ApplyPagination protected virtual #139 (#144)

* stop excluding null values when filtering using notEqual (#114)

* stop excluding null values when filtering using notEqual
* add IgnoreNullsOnNotEqual config field, to enable/disable the new feature

Co-authored-by: AnasZakarneh <[email protected]>

Co-authored-by: Clayton Andersen <[email protected]>
Co-authored-by: Clayton Andersen <[email protected]>
Co-authored-by: ITDancer139 <[email protected]>
Co-authored-by: Hasan Manzak <[email protected]>
Co-authored-by: alicak <[email protected]>
Co-authored-by: AnasZakarneh <[email protected]>
Co-authored-by: AnasZakarneh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.5
Development

Successfully merging a pull request may close this issue.

Make ApplyFiltering, ApplySorting and ApplyPagination protected virtu… Biarity/Sieve
1 participant
@ITDancer13