Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use image_url from API response #351

Open
Libisch opened this issue Apr 27, 2017 · 3 comments
Open

Use image_url from API response #351

Libisch opened this issue Apr 27, 2017 · 3 comments

Comments

@Libisch
Copy link
Contributor

Libisch commented Apr 27, 2017 •
edited
Loading

Overview

  • On item page, front needs an image URL in order to present the image.
  • All though the correct 'mail_image_url' is included in the API response, front does not use it, and generates a URL.
  • The image URL (for all pictures) should be taken from the API response and not generated.

Reproduce:

  • In general search box, enter "Zakopane"
  • Click on one of the results containing "Courtesy of ... bagnowka.pl" (example).

screen shot 2017-05-21 at 13 33 51

* API response includes a correct `main_image_url` (to AWS s3, apposed to BH original items, stored in google cloud storage)

screen shot 2017-05-21 at 13 29 30

Expected:
See images

Current:
Images are not available.

screen shot 2017-05-21 at 13 32 26
@Libisch Libisch mentioned this issue Apr 30, 2017
Open
@TheGrandVizier TheGrandVizier added this to the High Priority Front milestone May 15, 2017
@TheGrandVizier
Copy link
Contributor

@daonb may be able to assist @Libisch

@Libisch
Copy link
Contributor Author

Libisch commented May 21, 2017

@TheGrandVizier @Inna-r
See updated issue. I can't do this by myself, please priorities so we can move on to other scrapings

@Libisch Libisch mentioned this issue May 23, 2017
Open
@Libisch
Copy link
Contributor Author

Libisch commented May 23, 2017

Added precondition:
In addition to main_image_url, API should provide a URL for each image (see dbs-back PR 178)

Inna-r added a commit to Inna-r/dbs-front that referenced this issue May 24, 2017
@Inna-r
Use image_url from API response
8bc1b59 
issue Beit-Hatfutsot#351
@Inna-r Inna-r mentioned this issue May 24, 2017
Open
Inna-r added a commit to Inna-r/dbs-front that referenced this issue May 25, 2017
@Inna-r
1.the number of diagonal lines on item preview card now depends on the
f0d0c65 
length of sorted item's pictures array
2.display fallback picture for broken picture on item preview card

issue Beit-Hatfutsot#351
@Libisch Libisch mentioned this issue Jun 13, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheGrandVizier @Libisch