Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate correct image_url for Items from external sources #157

Open
Libisch opened this issue Apr 27, 2017 · 3 comments
Open

Generate correct image_url for Items from external sources #157

Libisch opened this issue Apr 27, 2017 · 3 comments
Assignees

Comments

@Libisch
Copy link
Contributor

Libisch commented Apr 27, 2017

  • Data scraped from Bakgnowka was converted to photoUnits docs
  • The images are stored in AWS, apposed to BHP images which are stored in gcloud.
  • Currently all image_urls are automaticaly assigned to google storage:
    https://storage.googleapis.com/bhs-flat-pics/[PicturId].jpg

Expected
API endpoints should identify this and assign the correct url for 'main_image_url':
https://s3-us-west-2.amazonaws.com/bagnowka-scraped/full/[_PicturId_].jpg

@Libisch
Copy link
Contributor Author

Libisch commented Apr 30, 2017

@OriHoch Maybe we should change just the frontend (which is where the image_url is currently generated), and wait with bhs_api endpoints until clearmash is integrated?
Anyway, I'll need some help from @inna because testing changes couldn't be preformed without changing the frontend (#351).

As to the items, they are fit and ready, except for the images (locally):
(1/2) Search results:
screen shot 2017-04-30 at 14 01 53

(2/2) Item page:
screen shot 2017-04-30 at 14 05 37

@Libisch
Copy link
Contributor Author

Libisch commented May 10, 2017

Done. API returns correct url:
screen shot 2017-05-10 at 15 55 03

@TheGrandVizier
Copy link

Waiting for itempage 404 to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants