Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use image_url from API response #405

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Inna-r
Copy link
Contributor

@Inna-r Inna-r commented May 24, 2017

issue #351

  • Templates use image URLs from API
  • Added directive for image URL validation
    • broken URLs are redirected
  • item page and galleries should not show broken images

notes

  • there are 3 types of images:
    1. digitizied image with valid and accessible image file
    2. not digitized image - physical item which doesn't have related image file
    3. (what appears like) a digitized image - but doesn't have related and accessible image file

@Libisch Libisch requested a review from OriHoch May 24, 2017 13:12
Copy link
Contributor

@OriHoch OriHoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Inna-r some more documentation is needed / examples of the different types of items, reproduction steps etc..

@Libisch
Copy link
Contributor

Libisch commented Jun 11, 2017

@OriHoch - I'll try to review the current situation, so we can decide on how to proceed with this issue. @TheGrandVizier please correct me if I'm wrong:

Currently, there are three types of pictures (Item['Pictures']) in photoUnits:
1. picture does not have a pictureId, therefore does not have a PictureUrl:
Item page, Pictures[1]:
screen shot 2017-06-11 at 14 56 27

2. picture has a PictureId, has a PictureUrl, but it's not valid:
Item page, Pictures[0]:
screen shot 2017-06-11 at 14 53 10

3. picture has a valid PictureId and there for has a valid PictureUrl:
Item page, Picture[0]:
screen shot 2017-06-11 at 15 02 28

Reproduce:

  • Open item pages (1, 2, 3)
  • Expected:
    Item page should present only valid photos
  • Actual:
    1- Item page presents a "not yet digitized" thumbnail, link leads to a volunteering page on bh.org.il.
    2- Item page presents a broken image thumbnail and link returns ["Access denied"]
    3- Item page presents valid thumbnails and links to storage are valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants