Bug and compliance fixes #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alelom
changed the title
alelom
added
type:compliance
alelom
changed the title
al-fisher
approved these changes
Sep 18, 2020
There was a problem hiding this comment.
LGTM
Ran through test scripts following review. All working as expected.
As discussed @alelom - the "BHoM File" of type currently BH.oM.Adapters.Filing.File could make sense to promote into a central non-Adapter oM. This will help distingish it further as a concept for the current Filing System file and the SharePoint File.
I will raise a separate issue on this to discuss and pick up in 4.0.
Happy to merge this
|
/azp run Filing_Toolkit.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #51
Closes #50
Closes #53
Closes #54
Test files
This folder contains various test files:
https://burohappold.sharepoint.com/:f:/s/BHoM/Ejfxf3gk6rpMqtNV1qNXws0B3W7qAzCBXxXdxK269FJiWw?e=FbR08z
All test files are quite straightforward. They also can be followed using the related Test procedure:
https://burohappold.sharepoint.com/:w:/s/BHoM/EVWMrt6uTxpGubryxTlpmIABtA3ssfTVIhXkwViOIJZpxQ?e=jfxKAz
Changelog
Additional comments