Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class definition not compliant for serialisation #54

Closed
adecler opened this issue Sep 16, 2020 · 0 comments · Fixed by #52
Closed

Class definition not compliant for serialisation #54

adecler opened this issue Sep 16, 2020 · 0 comments · Fixed by #52
Assignees
@alelom @adecler
Labels
type:compliance Non-conforming to code guidelines
Milestone
BHoM 3.3 β Release

Comments

@adecler
Copy link
Member

adecler commented Sep 16, 2020

Broken rules:

Some types in this toolkit are not serialising correctly. This is due to the Name property being overwritten using new instead of override 😕

Suggestions to restore compliance:

use override instead of new
@adecler adecler added the type:compliance Non-conforming to code guidelines label Sep 16, 2020
@adecler adecler added this to the BHoM 3.3 β Release milestone Sep 16, 2020
@adecler adecler mentioned this issue Sep 16, 2020
Closed
alelom added a commit that referenced this issue Sep 16, 2020
@alelom
Fixing #54
9e7b4ef
@alelom alelom mentioned this issue Sep 16, 2020
Merged
al-fisher pushed a commit that referenced this issue Sep 18, 2020
@alelom @al-fisher
Fixing #54
df319b1
@adecler adecler mentioned this issue Jan 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alelom alelom

@adecler adecler

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
BHoM 3.3 β Release
Development

Successfully merging a pull request may close this issue.

Bug and compliance fixes BHoM/File_Toolkit
Fix non-compliant type definition BHoM/File_Toolkit
2 participants
@alelom @adecler