Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BH.oM.Adapters.Filing.File object into non-Adapters namespace #56

Open
al-fisher opened this issue Sep 18, 2020 · 0 comments
Open
Assignees
Labels
type:compliance Non-conforming to code guidelines

Comments

@al-fisher
Copy link
Member

As discussed in the PR comment #52 (review)
Suggest migration of the BH.oM.Adapters.Filing.File into a non-adapters namespace to more clearly denote it as the agnostic BHoM definition of a file. i.e. sits in a oM namespace such as BH.oM.Filing without the Adapters

This neutral BH.oM.Filing.File - is then converted into the SharePoint File or Filing System file as part of the Adapter process.

With this change to namespace for the core File - I might then suggest something like BH.oM.Adapters.SystemFiling.File instead of SFFile to more clearly denote the file type. Leaning on the namespaces for clarity as per other disciplines.

On the canvas then when creating a "File" - will be logical to use the BH.oM.Filing.File as all the others will be in Adapter namespaces, I think

@rwemay @alelom FYI

@al-fisher al-fisher added the type:compliance Non-conforming to code guidelines label Sep 18, 2020
@al-fisher al-fisher added this to the BHoM 4.0 β MVP milestone Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

No branches or pull requests

2 participants