Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avm/res/search/search-service improvements #3074

Merged
merged 6 commits into from
Aug 21, 2024

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Aug 20, 2024

Description

PR contains a few improvements of the avm/res/search/search-service module:

Pipeline Reference

Pipeline
avm.res.search.search-service

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@krbar krbar self-assigned this Aug 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Aug 20, 2024
@krbar krbar added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Aug 20, 2024
@krbar krbar marked this pull request as ready for review August 20, 2024 17:55
@krbar krbar requested review from a team as code owners August 20, 2024 17:56
@AlexanderSehr AlexanderSehr merged commit 6df8e94 into Azure:main Aug 21, 2024
5 checks passed
@krbar krbar deleted the users/krbar/searchUpdates branch August 22, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
2 participants