-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add key vault to search service - avm/res/search/search-service
#1950
Conversation
This reverts commit e4e0366.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mortenvpschmidt thanks for addressing the comment and for this contribution. Be aware this falls into the same discussion opened by @Agazoth here #1934.
I'd therefore put this PR on hold until an agreement is made there.
@eriqua and @AlexanderSehr I am so sorry - I completely missed the comment. I have updated the code and it is currently running the final test (removing resources) Looking forward to the merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then let's put a stamp on this piece of work! Thank you @Agazoth for your awesome work and also to all, who contributed!
Add option for outputting admin keys to search service
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.