Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add key vault to search service - avm/res/search/search-service #1950

Merged
merged 38 commits into from
Oct 1, 2024

Conversation

mortenvpschmidt
Copy link
Contributor

Add option for outputting admin keys to search service

Pipeline Reference

Pipeline
avm.res.search.search-service

Type of Change

  • Update to CI Environment or utilities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@mortenvpschmidt mortenvpschmidt requested review from a team as code owners May 16, 2024 09:48
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels May 16, 2024
ReneHezser
ReneHezser previously approved these changes May 16, 2024
eriqua
eriqua previously requested changes May 17, 2024
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mortenvpschmidt thanks for addressing the comment and for this contribution. Be aware this falls into the same discussion opened by @Agazoth here #1934.
I'd therefore put this PR on hold until an agreement is made there.

@eriqua eriqua removed the Needs: Triage 🔍 Maintainers need to triage still label May 17, 2024
@eriqua eriqua removed request for a team and eriqua September 27, 2024 16:43
@eriqua eriqua dismissed their stale review September 27, 2024 16:44

Secrets export interface published

@eriqua eriqua added Class: Resource Module 📦 This is a resource module Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Sep 27, 2024
@Agazoth
Copy link
Contributor

Agazoth commented Sep 27, 2024

@eriqua and @AlexanderSehr I am so sorry - I completely missed the comment. I have updated the code and it is currently running the final test (removing resources) Looking forward to the merge!

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Sep 27, 2024
Copy link
Contributor

@krbar krbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then let's put a stamp on this piece of work! Thank you @Agazoth for your awesome work and also to all, who contributed!

@krbar krbar merged commit 7d6600c into Azure:main Oct 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Question/Feedback 🙋 Further information is requested or just some feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants