Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: Search Service module to output Private Endpoint IP(s) #3022

Closed
1 task done
aheinenwbmi opened this issue Aug 9, 2024 · 4 comments · Fixed by #3074
Closed
1 task done

[AVM Module Issue]: Search Service module to output Private Endpoint IP(s) #3022

aheinenwbmi opened this issue Aug 9, 2024 · 4 comments · Fixed by #3074
Assignees
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@aheinenwbmi
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/search/search-service

(Optional) Module Version

No response

Description

The private endpoint module outputs the IP address of the private endpoint NIC but the search service module which calls that private endpoint module doesnt output the IP address of the private endpoint NIC. It would be nice to have that output so I can create an A record for that IP address without having to call the private endpoint as an existing resource in my bicep file after the search service deploys.

(Optional) Correlation Id

No response

@aheinenwbmi aheinenwbmi added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Aug 9, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Aug 9, 2024
Copy link

@aheinenwbmi, thanks for submitting this issue for the avm/res/search/search-service module!

Important

A member of the @Azure/avm-res-search-searchservice-module-owners-bicep or @Azure/avm-res-search-searchservice-module-contributors-bicep team will review it soon!

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Aug 15, 2024
@krbar
Copy link
Contributor

krbar commented Aug 20, 2024

@aheinenwbmi I will add an output privateEndpoints with the properties of the private endpoints, which are available as outputs of the avm/res/network/private-endpoint module, like: name, resourceId, groupId, customDnsConfig, networkInterfaceIds.
I hope this helps.

@krbar krbar removed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels Aug 20, 2024
@github-project-automation github-project-automation bot moved this from Needs: Triage to Done in AVM - Module Issues Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants