fixing failing workflow runs for encrypted eventhub #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
|
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
microsoft-github-policy-service
bot
added
the
Type: AVM 🅰️ ✌️ Ⓜ️
11 tasks
AlexanderSehr
approved these changes
Jun 14, 2024
elanzel
added
Needs: Core Team 🧞
eriqua
reviewed
Jun 16, 2024
| @@ -17,6 +17,8 @@ spec: | |||
| - Azure.Automation.ManagedIdentity | |||
| - Azure.Automation.AuditLogs # Diagnostic Settings cannot be set by default, but require user input | |||
| - Azure.Automation.PlatformLogs # Diagnostic Settings cannot be set by default, but require user input | |||
| # Event Hub specific | |||
| - Azure.EventHub.Firewall | |||
There was a problem hiding this comment.
@AlexanderSehr @elanzel going forward I'd suggest to add a comment next to the exempted rule with a brief reason for the exeption.
11 tasks
hundredacres
pushed a commit
to hundredacres/bicep-registry-modules
that referenced
this pull request
Jun 19, 2024
## Description Fixes the issues on encrypted eventhub deployment that was due to publicNetworkAccess set to "SecuredbyPerimeter" fixes Azure#1729 ## Pipeline Reference | Pipeline | | -------- | | [](https://github.com/elanzel/bicep-registry-modules/actions/workflows/avm.res.event-hub.namespace.yml) | ## Type of Change - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [ ] Azure Verified Module updates: - [x] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [x] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings
](https://github.com/elanzel/bicep-registry-modules/actions/workflows/avm.res.event-hub.namespace.yml){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issues on encrypted eventhub deployment that was due to publicNetworkAccess set to "SecuredbyPerimeter"
fixes #1729
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.