Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing failing workflow runs for encrypted eventhub #2361

Merged
merged 3 commits into from
Jun 14, 2024
Merged

fixing failing workflow runs for encrypted eventhub #2361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f65e806
removed publicnetworkaccess securedbyperimeter
elanzel Jun 14, 2024
f44862a
PS rule exception for default
elanzel Jun 14, 2024
e3ea359
removed fw rule in encripted eh
elanzel Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions avm/res/event-hub/namespace/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ module namespace 'br/public:avm/res/event-hub/namespace:<version>' = {
'<managedIdentityResourceId>'
]
}
publicNetworkAccess: 'SecuredByPerimeter'
requireInfrastructureEncryption: true
skuName: 'Premium'
}
Expand Down Expand Up @@ -159,9 +158,6 @@ module namespace 'br/public:avm/res/event-hub/namespace:<version>' = {
]
}
},
"publicNetworkAccess": {
"value": "SecuredByPerimeter"
},
"requireInfrastructureEncryption": {
"value": true
},
Expand Down
4 changes: 2 additions & 2 deletions avm/res/event-hub/namespace/authorization-rule/main.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "15327912662565121564"
"version": "0.28.1.47646",
"templateHash": "16196850257533249972"
},
"name": "Event Hub Namespace Authorization Rule",
"description": "This module deploys an Event Hub Namespace Authorization Rule.",
Expand Down
4 changes: 2 additions & 2 deletions avm/res/event-hub/namespace/disaster-recovery-config/main.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "11732013494690054024"
"version": "0.28.1.47646",
"templateHash": "11958192120414683611"
},
"name": "Event Hub Namespace Disaster Recovery Configs",
"description": "This module deploys an Event Hub Namespace Disaster Recovery Config.",
Expand Down
4 changes: 2 additions & 2 deletions avm/res/event-hub/namespace/eventhub/authorization-rule/main.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "15301134976738274567"
"version": "0.28.1.47646",
"templateHash": "13970780399709322534"
},
"name": "Event Hub Namespace Event Hub Authorization Rules",
"description": "This module deploys an Event Hub Namespace Event Hub Authorization Rule.",
Expand Down
4 changes: 2 additions & 2 deletions avm/res/event-hub/namespace/eventhub/consumergroup/main.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "7757490711276971084"
"version": "0.28.1.47646",
"templateHash": "10439838475562052342"
},
"name": "Event Hub Namespace Event Hub Consumer Groups",
"description": "This module deploys an Event Hub Namespace Event Hub Consumer Group.",
Expand Down
12 changes: 6 additions & 6 deletions avm/res/event-hub/namespace/eventhub/main.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "14538170733088329405"
"version": "0.28.1.47646",
"templateHash": "5745450341554942810"
},
"name": "Event Hub Namespace Event Hubs",
"description": "This module deploys an Event Hub Namespace Event Hub.",
Expand Down Expand Up @@ -416,8 +416,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "7757490711276971084"
"version": "0.28.1.47646",
"templateHash": "10439838475562052342"
},
"name": "Event Hub Namespace Event Hub Consumer Groups",
"description": "This module deploys an Event Hub Namespace Event Hub Consumer Group.",
Expand Down Expand Up @@ -520,8 +520,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "15301134976738274567"
"version": "0.28.1.47646",
"templateHash": "13970780399709322534"
},
"name": "Event Hub Namespace Event Hub Authorization Rules",
"description": "This module deploys an Event Hub Namespace Event Hub Authorization Rule.",
Expand Down
28 changes: 14 additions & 14 deletions avm/res/event-hub/namespace/main.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "5884251970985873966"
"version": "0.28.1.47646",
"templateHash": "5395452802067789648"
},
"name": "Event Hub Namespaces",
"description": "This module deploys an Event Hub Namespace.",
Expand Down Expand Up @@ -854,8 +854,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "15327912662565121564"
"version": "0.28.1.47646",
"templateHash": "16196850257533249972"
},
"name": "Event Hub Namespace Authorization Rule",
"description": "This module deploys an Event Hub Namespace Authorization Rule.",
Expand Down Expand Up @@ -951,8 +951,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "11732013494690054024"
"version": "0.28.1.47646",
"templateHash": "11958192120414683611"
},
"name": "Event Hub Namespace Disaster Recovery Configs",
"description": "This module deploys an Event Hub Namespace Disaster Recovery Config.",
Expand Down Expand Up @@ -1067,8 +1067,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "14538170733088329405"
"version": "0.28.1.47646",
"templateHash": "5745450341554942810"
},
"name": "Event Hub Namespace Event Hubs",
"description": "This module deploys an Event Hub Namespace Event Hub.",
Expand Down Expand Up @@ -1478,8 +1478,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "7757490711276971084"
"version": "0.28.1.47646",
"templateHash": "10439838475562052342"
},
"name": "Event Hub Namespace Event Hub Consumer Groups",
"description": "This module deploys an Event Hub Namespace Event Hub Consumer Group.",
Expand Down Expand Up @@ -1582,8 +1582,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "15301134976738274567"
"version": "0.28.1.47646",
"templateHash": "13970780399709322534"
},
"name": "Event Hub Namespace Event Hub Authorization Rules",
"description": "This module deploys an Event Hub Namespace Event Hub Authorization Rule.",
Expand Down Expand Up @@ -1718,8 +1718,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "3984181780336367181"
"version": "0.28.1.47646",
"templateHash": "4849410286147918309"
},
"name": "Event Hub Namespace Network Rule Sets",
"description": "This module deploys an Event Hub Namespace Network Rule Set.",
Expand Down
4 changes: 2 additions & 2 deletions avm/res/event-hub/namespace/network-rule-set/main.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "3984181780336367181"
"version": "0.28.1.47646",
"templateHash": "4849410286147918309"
},
"name": "Event Hub Namespace Network Rule Sets",
"description": "This module deploys an Event Hub Namespace Network Rule Set.",
Expand Down
1 change: 0 additions & 1 deletion avm/res/event-hub/namespace/tests/e2e/encr/main.test.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ module testDeployment '../../../main.bicep' = {
params: {
name: '${namePrefix}${serviceShort}001'
location: resourceLocation
publicNetworkAccess: 'SecuredByPerimeter'
skuName: 'Premium'
managedIdentities: {
systemAssigned: false
Expand Down
2 changes: 2 additions & 0 deletions avm/utilities/pipelines/staticValidation/psrule/.ps-rule/min-suppress.Rule.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ spec:
- Azure.Automation.ManagedIdentity
- Azure.Automation.AuditLogs # Diagnostic Settings cannot be set by default, but require user input
- Azure.Automation.PlatformLogs # Diagnostic Settings cannot be set by default, but require user input
# Event Hub specific
- Azure.EventHub.Firewall
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexanderSehr @elanzel going forward I'd suggest to add a comment next to the exempted rule with a brief reason for the exeption.

# Key Vault specific
- Azure.KeyVault.Logs
- Azure.KeyVault.Firewall
Expand Down
Loading