-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: api version update + fixing failing workflow runs - avm/res/event-hub/namespace
#2004
Conversation
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. Note This label was added as per ITA06. |
Note The "Type: AVM |
avm/res/event-hub/namespace
avm/res/event-hub/namespace
avm/res/event-hub/namespace
@@ -53,7 +53,7 @@ module testDeployment '../../../main.bicep' = { | |||
scope: resourceGroup | |||
name: '${uniqueString(deployment().name, resourceLocation)}-test-${serviceShort}' | |||
params: { | |||
name: '${namePrefix}${serviceShort}001' | |||
name: '${namePrefix}${serviceShort}${substring(uniqueString(baseTime), 0, 3)}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @segraef could you elaborate why this was changed? Just curious, as it take away the possiblity to test this deployment in an idempontent way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AlexanderSehr the unique name should solve a conflict when deploying the encrypted eventhub:
VERBOSE: 11:05:03 - The deployment 'a-r-eh-n-encr-t1-20240612T1106073886Z' failed with error(s). Showing 1 out of 1 error(s).
Status Message: At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details. (Code: DeploymentFailed)
- The resource write operation failed to complete successfully, because it reached terminal provisioning state 'Failed'. (Code:ResourceDeploymentFailure)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but when I take a look at the last failed pipelines I see 3 erros through 3 attempts
1.
The deployment 'a-r-eh-n-encr-t1-20240612T1106073886Z' failed with error(s). Showing 1 out of 1 error(s).
Status Message: At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details. (Code: DeploymentFailed)
- The resource write operation failed to complete successfully, because it reached terminal provisioning state 'Failed'. (Code:ResourceDeploymentFailure)
2.
The deployment 'a-r-eh-n-encr-t2-20240612T1106082182Z' failed with error(s). Showing 2 out of 2 error(s).
Status Message: Namespace name '***ehnenc001' is not available. Reason: NameInUse. Message: Name already in use (Code:NamespaceUnavailable)
Status Message: At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details. (Code: DeploymentFailed)
- Namespace name '***ehnenc001' is not available. Reason: NameInUse. Message: Name already in use (Code:NamespaceUnavailable)
3.
The deployment 'a-r-eh-n-encr-t3-20240612T1106487953Z' failed with error(s). Showing 2 out of 2 error(s). Status Message: Namespace name '***ehnenc001' is not available. Reason: NameInUse. Message: Name already in use (Code:NamespaceUnavailable)
Status Message: At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details. (Code: DeploymentFailed)
- Namespace name '***ehnenc001' is not available. Reason: NameInUse. Message: Name already in use (Code:NamespaceUnavailable)
Of which only the first is really relevant as all others could be / are follow-up errors as the Namespace from Attempt 1 is still around (and later the one from Attempt 2.
I don't think we're actually fixing the error, but just masking it by deploying 3 different Namespaces.
I would suggest to run the deployment of the encr
test once without the removal (which will likely fail) and then look into the deployment and find the actual cause of the error. The resource write operation failed to complete successfully
isn't exactly saying much.
My guess is that we have similar issues like we have with other modules where the permissions for the key vault key take longer to propagate than the deployment is willing to wait (which is super nasty by the way). If that turns out to be the case here too, then we should fix that instead. Likely by adding some wait logic via an inline deployment script, as annoying as it may be.
Am I making sense 😄 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found that the issue on deployment failure was related to the publicNetworkAccess parameter set to "SecuredByPerimeter". Solved in PR #2361
Setting this PR to draft, we'll use this for the API update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, look at this who could've guess this. Great work thanks @elanzel !
Pull request was converted to draft
Hey @segraef, |
Description
Closes #1729 (might be closed already) and future failing workflow runs.
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.