feat: Update PE implementation in alignment to latest schema (5) #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Currently testing all multi-PE services as per https://learn.microsoft.com/en-us/azure/private-link/private-endpoint-overview#private-link-resource Private-link resource name | Resource type | Sub-resources -- | -- | -- Azure Automation | Microsoft.Automation/automationAccounts | Webhook, DSCAndHybridWorker Azure Backup | Microsoft.RecoveryServices/vaults | AzureBackup, AzureSiteRecovery Azure Batch | Microsoft.Batch/batchAccounts | batchAccount, nodeManagement Azure Cosmos DB | Microsoft.AzureCosmosDB/databaseAccounts | SQL, MongoDB, Cassandra, Gremlin, Table Azure Databricks | Microsoft.Databricks/workspaces | databricks_ui_api, browser_authentication Azure Media Services | Microsoft.Media/mediaservices | keydelivery, liveevent, streamingendpoint Azure Storage | Microsoft.Storage/storageAccounts | Blob (blob, blob_secondary)Table (table, table_secondary)Queue (queue, queue_secondary)File (file, file_secondary)Web (web, web_secondary)Dfs (dfs, dfs_secondary) Azure Synapse Analytics | Microsoft.Synapse/workspaces | Sql, SqlOnDemand, Dev Closes - Azure/Azure-Verified-Modules#620 - #962 - #946 - #1042 AVM Issues - Azure/Azure-Verified-Modules#621 ## Pipeline Reference | Pipeline | | -------- | | [](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.automation.automation-account.yml) | | [](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.batch.batch-account.yml)| | [](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.databricks.workspace.yml)| | [](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.document-db.database-account.yml)| | [](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.storage.storage-account.yml)| | [](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.synapse.workspace.yml) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [x] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [x] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep --> --------- Co-authored-by: Kris Baranek <[email protected]>
## Description added additional PE tests follow up to #1070 ## Pipeline Reference | Pipeline | | -------- | | [](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.automation.automation-account.yml) | | [](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.batch.batch-account.yml)| | [](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.databricks.workspace.yml)| | [](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.document-db.database-account.yml)| | [](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.storage.storage-account.yml)| | [](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.synapse.workspace.yml) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [x] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [x] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep -->
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
This was
linked to
issues
Feb 27, 2024
|
@AlexanderSehr - @clintgrove is currently working on these modules, should be pull the changes from this branch and include it in his bulk changes? |
If he is working on them, great - but - the question is if he'd also upgrade the PE implementation + test. If not, then the change could be merged independenty if approved. But for that, the pipelines must start working fist. |
|
Hey @clintgrove, |
Hi @AlexanderSehr no, please go ahead with this PR. I did notice that a private endpoint was missing "browser_auth" and was going to work on it, but I am glad to see that you have already found a fix and have implemented it here. I am happy that this PR goes in and I can work around whatever changes are done here |
ChrisSidebotham
approved these changes
Mar 19, 2024
](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.automation.automation-account.yml){kind=link}
|](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.batch.batch-account.yml/badge.svg?branch=fix%2Fpe-schema)](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.batch.batch-account.yml)|){kind=link}
|](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.databricks.workspace.yml/badge.svg?branch=fix%2Fpe-schema)](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.databricks.workspace.yml)|){kind=link}
|](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.document-db.database-account.yml/badge.svg?branch=fix%2Fpe-schema)](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.document-db.database-account.yml)|){kind=link}
|](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.storage.storage-account.yml/badge.svg?branch=fix%2Fpe-schema)](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.storage.storage-account.yml)|){kind=link}
](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.synapse.workspace.yml){kind=link}
](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.automation.automation-account.yml){kind=link}
|](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.batch.batch-account.yml/badge.svg?branch=feat%2Fpe-tests-add)](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.batch.batch-account.yml)|){kind=link}
|](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.databricks.workspace.yml/badge.svg?branch=feat%2Fpe-tests-add)](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.databricks.workspace.yml)|){kind=link}
|](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.document-db.database-account.yml/badge.svg?branch=feat%2Fpe-tests-add)](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.document-db.database-account.yml)|){kind=link}
|](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.storage.storage-account.yml/badge.svg?branch=feat%2Fpe-tests-add)](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.storage.storage-account.yml)|){kind=link}
](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.synapse.workspace.yml){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #1070
private-endpointtests cases if already implemented in maxPipeline Reference
Type of Change
version.json:version.json.version.json.