Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question/Feedback]: PE schema adjustments #620

Closed
1 task done
segraef opened this issue Feb 7, 2024 · 1 comment
Closed
1 task done

[Question/Feedback]: PE schema adjustments #620

segraef opened this issue Feb 7, 2024 · 1 comment
Assignees
Labels
Language: Bicep 💪 This is related to the Bicep IaC language Type: Documentation 📄 Improvements or additions to documentation Type: Question/Feedback 🙋 Further information is requested or just some feedback

Comments

@segraef
Copy link
Contributor

segraef commented Feb 7, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Description

Opening this issue in correspondence with Azure/bicep-registry-modules#946 to track PE schema adjustments.

@segraef segraef added Needs: Triage 🔍 Maintainers need to triage still Type: Question/Feedback 🙋 Further information is requested or just some feedback labels Feb 7, 2024
@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Issue Triage Feb 7, 2024
@segraef
Copy link
Contributor Author

segraef commented Feb 7, 2024

@matebarabas matebarabas added Language: Bicep 💪 This is related to the Bicep IaC language Type: Documentation 📄 Improvements or additions to documentation and removed Needs: Triage 🔍 Maintainers need to triage still labels Feb 7, 2024
@matebarabas matebarabas moved this from Needs: Triage to In Active Discussion in AVM - Issue Triage Feb 9, 2024
AlexanderSehr pushed a commit to Azure/bicep-registry-modules that referenced this issue Feb 25, 2024
## Description
Currently testing all multi-PE services as per
https://learn.microsoft.com/en-us/azure/private-link/private-endpoint-overview#private-link-resource

Private-link resource name | Resource type | Sub-resources
-- | -- | --
Azure Automation | Microsoft.Automation/automationAccounts | Webhook,
DSCAndHybridWorker
Azure Backup | Microsoft.RecoveryServices/vaults | AzureBackup,
AzureSiteRecovery
Azure Batch | Microsoft.Batch/batchAccounts | batchAccount,
nodeManagement
Azure Cosmos DB | Microsoft.AzureCosmosDB/databaseAccounts | SQL,
MongoDB, Cassandra, Gremlin, Table
Azure Databricks | Microsoft.Databricks/workspaces | databricks_ui_api,
browser_authentication
Azure Media Services | Microsoft.Media/mediaservices | keydelivery,
liveevent, streamingendpoint
Azure Storage | Microsoft.Storage/storageAccounts | Blob (blob,
blob_secondary)Table (table, table_secondary)Queue (queue,
queue_secondary)File (file, file_secondary)Web (web, web_secondary)Dfs
(dfs, dfs_secondary)
Azure Synapse Analytics | Microsoft.Synapse/workspaces | Sql,
SqlOnDemand, Dev

Closes
- Azure/Azure-Verified-Modules#620
- #962
- #946
- #1042

AVM Issues
- Azure/Azure-Verified-Modules#621

## Pipeline Reference

| Pipeline |
| -------- |
|
[![avm.res.automation.automation-account](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.automation.automation-account.yml/badge.svg?branch=fix%2Fpe-schema)](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.automation.automation-account.yml)
|
|
[![avm.res.batch.batch-account](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.batch.batch-account.yml/badge.svg?branch=fix%2Fpe-schema)](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.batch.batch-account.yml)|
|
[![avm.res.databricks.workspace](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.databricks.workspace.yml/badge.svg?branch=fix%2Fpe-schema)](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.databricks.workspace.yml)|
|
[![avm.res.document-db.database-account](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.document-db.database-account.yml/badge.svg?branch=fix%2Fpe-schema)](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.document-db.database-account.yml)|
|
[![avm.res.storage.storage-account](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.storage.storage-account.yml/badge.svg?branch=fix%2Fpe-schema)](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.storage.storage-account.yml)|
|
[![avm.res.synapse.workspace](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.synapse.workspace.yml/badge.svg?branch=fix%2Fpe-schema)](https://github.com/segraef/bicep-registry-modules/actions/workflows/avm.res.synapse.workspace.yml)
|



## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [x] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [x] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [x] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

---------

Co-authored-by: Kris Baranek <[email protected]>
@segraef segraef closed this as completed Mar 11, 2024
@github-project-automation github-project-automation bot moved this from In Active Discussion to Done in AVM - Issue Triage Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language: Bicep 💪 This is related to the Bicep IaC language Type: Documentation 📄 Improvements or additions to documentation Type: Question/Feedback 🙋 Further information is requested or just some feedback
Projects
Development

No branches or pull requests

2 participants