[AVM Module Issue]: Duplicate Private Link service connection names in all modules

[tyconsulting]

Check for previous/existing GitHub issues

• I have checked for previous/existing GitHub issues

Issue Type?

Bug

Module Name

Other, as defined below...

(Optional) Module Name if not listed above

All modules that create Private Endpoints

(Optional) Module Version

No response

Description

When multiple private endpoints are defined, the PL service connection name are the same:

To fix this bug, this is what I have done:

1. in the module calling the PE module, extend the privateEndpointType by adding an additional property:

  @description('Optional. The name of the Private Link Service Connection.')
  privateLinkServiceConnectionName: string?

2. When calling the PE module, update the name property inside privateLinkServiceConnections to name: privateEndpoint.?privateLinkServiceConnectionName ?? '${name}-${index}' i.e.

AND

This will allow me to give it a more meaningful name if required, and if I don't specify a name, a numeric character will append to the end of the name ('${name}-${index}')

This is the end result:

(Optional) Correlation Id

No response

[tyconsulting]

Hi @segraef @AlexanderSehr this is also related to the multiple PE discussion we had few days ago (#962).

[segraef]

Thanks @tyconsulting, having a look at it.

[AlexanderSehr]

We're starting to pile them up. Thanks for all the great feedback @tyconsulting. @segraef, I guess right now everything is just waiting on the schema approval, right? I'd suggest to add this one in there as well, if you'd agree.

As an alternative we could however also re-use the private endpoint name logic, right? There's only ever one private link connection per private endpoint, so if we'd also be using the following it should also work (key vault example):

name: privateEndpoint.?name ?? '${last(split(<singularMainResourceType>.id, '/'))}-${privateEndpoint.?service ?? '<defaultServiceName>'}-${index}'

Though instead of saying privateEndpoint.?name in the front, we could also use privateEndpoint.?privateLinkServiceConnectionName as per your suggestion.
That would be:

name: privateEndpoint.?privateLinkServiceConnectionName ?? '${last(split(<singularMainResourceType>.id, '/'))}-${privateEndpoint.?service ?? '<defaultServiceName>'}-${index}'

and the same for the manual connection.

[microsoft-github-policy-service]

Tagging the AVM Core Team (@Azure/avm-core-team) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[segraef]

Implementation in progress, see linked PRs.