Add basic reason why package has been included to Package-Properties #8974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y) as well as pulling BuildDocs from ci.yml artifact list if it exists
|
The following pipelines have been queued for testing: |
…yaml to be present on our base function. not good
|
The following pipelines have been queued for testing: |
scbedd
changed the title
BuildDocs and Direct/Indirect indicator into Package-Properties
weshaggard
reviewed
Sep 16, 2024
weshaggard
approved these changes
Sep 16, 2024
This was referenced Sep 16, 2024
scbedd
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Sep 16, 2024
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8974 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Scott Beddall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
IncludedForValidation, defaults tofalse)AddBuildDocsproperty, which is calculated when a package props class is instantiated.I have a fairly strong suspicion, because of the necessary inclusion of(https://github.com/Azure/azure-sdk-for-python/blob/main/eng/scripts/Save-Package-Namespaces-Property.ps1)Install-ModuleIfNotInstalled "powershell-yaml" "0.4.1" | Import-Module, that we will just want to put this artifact parsing in the [docs namespace update directly.]I ripped out
BuildDocsbecause it implies thatpowershell-yamlwill become a base requirement of ourSave-Package-Propertiesnamespace. We ALREADY see some failures to install modules just based on normal usage in a few select pipelines. I feel like if I force every single pipeline to go through installing powershell-yaml, our random issues are going to skyrocket.What do ya'll think? @weshaggard @benbp