Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic reason why package has been included to Package-Properties #8974

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Add basic reason why package has been included to Package-Properties #8974

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
468d028
updating package properties with direct/indirect (if named differentl…
scbedd Sep 13, 2024
3cdb586
eliminate the addition of buildDocs property. it requires powershell-…
scbedd Sep 13, 2024
2a5ec8a
remove call to InitializeBuildDocs
scbedd Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions eng/common/scripts/Package-Properties.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ class PackageProps
[boolean]$IsNewSdk
[string]$ArtifactName
[string]$ReleaseStatus
# was this package purely included because other packages included it as an AdditionalValidationPackage?
[boolean]$IncludedForValidation
scbedd marked this conversation as resolved.
Show resolved Hide resolved
# does this package include other packages that we should trigger validation for?
[string[]]$AdditionalValidationPackages

PackageProps([string]$name, [string]$version, [string]$directoryPath, [string]$serviceDirectory)
Expand All @@ -38,6 +41,7 @@ class PackageProps
$this.Version = $version
$this.DirectoryPath = $directoryPath
$this.ServiceDirectory = $serviceDirectory
$this.IncludedForValidation = $false

if (Test-Path (Join-Path $directoryPath "README.md"))
{
Expand Down Expand Up @@ -143,6 +147,7 @@ function Get-PrPkgProperties([string]$InputDiffJson) {
$key = $addition.Replace($RepoRoot, "").TrimStart('\/')

if ($lookup[$key]) {
$lookup[$key].IncludedForValidation = $true
$packagesWithChanges += $lookup[$key]
}
}
Expand Down
Loading