Sync eng/common directory with azure-sdk-tools for PR 8974

[azure-sdk]

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8974 See eng/common workflow

[ahsonkhan]

It looks like the internal/live pipelines have started failing since this commit (only on Windows):
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4141559&view=results

I am not sure why such an eng/common change would cause cmake build step to fail.

Maybe there was an image update/MSVC compiler update at the same time uncovering this issue?
cc @LarryOsterman

A bunch of internal compiler errors show up on Windows, specifically for json.hpp:

2024-09-16T23:19:55.4282020Z Build FAILED.
2024-09-16T23:19:55.4286422Z 
2024-09-16T23:19:55.4288389Z        "D:\a\_work\1\s\build\ALL_BUILD.vcxproj" (default target) (1) ->
2024-09-16T23:19:55.4293980Z        "D:\a\_work\1\s\build\sdk\keyvault\azure-security-keyvault-administration\azure-security-keyvault-administration.vcxproj" (default target) (36) ->
2024-09-16T23:19:55.4295091Z        (ClCompile target) -> 
2024-09-16T23:19:55.4296638Z          d:\a\_work\1\s\build\sdk\keyvault\azure-security-keyvault-administration\predefined c++ types (compiler internal)(33): warning C28241: The annotation 'SAL_name' for 'new' on 'return' is not recognized. [D:\a\_work\1\s\build\sdk\keyvault\azure-security-keyvault-administration\azure-security-keyvault-administration.vcxproj]
2024-09-16T23:19:55.4298671Z          d:\a\_work\1\s\build\sdk\keyvault\azure-security-keyvault-administration\predefined c++ types (compiler internal)(33): warning C28285: For function 'new' 'return' syntax error in '("_Ret_notnull_","","2")' near '("_Ret_notnull_",""'. [D:\a\_work\1\s\build\sdk\keyvault\azure-security-keyvault-administration\azure-security-keyvault-administration.vcxproj]
2024-09-16T23:19:55.4300650Z          d:\a\_work\1\s\build\sdk\keyvault\azure-security-keyvault-administration\predefined c++ types (compiler internal)(33): warning C28241: The annotation 'SAL_name' for 'new' on 'return' is not recognized. [D:\a\_work\1\s\build\sdk\keyvault\azure-security-keyvault-administration\azure-security-keyvault-administration.vcxproj]
2024-09-16T23:19:55.4302913Z          d:\a\_work\1\s\build\sdk\keyvault\azure-security-keyvault-administration\predefined c++ types (compiler internal)(33): warning C28285: For function 'new' 'return' syntax error in '("_Post_writable_byte_size_","","2")' near '("_Post_writable_byte_size_",""'. [D:\a\_work\1\s\build\sdk\keyvault\azure-security-keyvault-administration\azure-security-keyvault-administration.vcxproj]
2024-09-16T23:19:55.4304981Z          d:\a\_work\1\s\build\sdk\keyvault\azure-security-keyvault-administration\predefined c++ types (compiler internal)(33): warning C28241: The annotation 'SAL_writableTo' for 'new' on 'return' is not recognized. [D:\a\_work\1\s\build\sdk\keyvault\azure-security-keyvault-administration\azure-security-keyvault-administration.vcxproj]
2024-09-16T23:19:55.4306880Z          d:\a\_work\1\s\build\sdk\keyvault\azure-security-keyvault-administration\predefined c++ types (compiler internal)(33): warning C28285: For function 'new' 'return' syntax error in '(byteCount(__formal(0,_Size)))' near '(byteCount(__formal(0'. [D:\a\_work\1\s\build\sdk\keyvault\azure-security-keyvault-administration\azure-security-keyvault-administration.vcxproj]
2024-09-16T23:19:55.4307848Z 
2024-09-16T23:19:55.4308280Z 
2024-09-16T23:19:55.4309043Z        "D:\a\_work\1\s\build\ALL_BUILD.vcxproj" (default target) (1) ->
2024-09-16T23:19:55.4310138Z        "D:\a\_work\1\s\build\sdk\tables\azure-data-tables\azure-data-tables.vcxproj" (default target) (18) ->
2024-09-16T23:19:55.4311835Z          d:\a\_work\1\s\build\sdk\tables\azure-data-tables\predefined c++ types (compiler internal)(33): warning C28241: The annotation 'SAL_name' for 'new' on 'return' is not recognized. [D:\a\_work\1\s\build\sdk\tables\azure-data-tables\azure-data-tables.vcxproj]
2024-09-16T23:19:55.4313843Z          d:\a\_work\1\s\build\sdk\tables\azure-data-tables\predefined c++ types (compiler internal)(33): warning C28285: For function 'new' 'return' syntax error in '("_Ret_notnull_","","2")' near '("_Ret_notnull_",""'. [D:\a\_work\1\s\build\sdk\tables\azure-data-tables\azure-data-tables.vcxproj]
2024-09-16T23:19:55.4316541Z          d:\a\_work\1\s\build\sdk\tables\azure-data-tables\predefined c++ types (compiler internal)(33): warning C28241: The annotation 'SAL_name' for 'new' on 'return' is not recognized. [D:\a\_work\1\s\build\sdk\tables\azure-data-tables\azure-data-tables.vcxproj]
2024-09-16T23:19:55.4319047Z          d:\a\_work\1\s\build\sdk\tables\azure-data-tables\predefined c++ types (compiler internal)(33): warning C28285: For function 'new' 'return' syntax error in '("_Post_writable_byte_size_","","2")' near '("_Post_writable_byte_size_",""'. [D:\a\_work\1\s\build\sdk\tables\azure-data-tables\azure-data-tables.vcxproj]
2024-09-16T23:19:55.4320946Z          d:\a\_work\1\s\build\sdk\tables\azure-data-tables\predefined c++ types (compiler internal)(33): warning C28241: The annotation 'SAL_writableTo' for 'new' on 'return' is not recognized. [D:\a\_work\1\s\build\sdk\tables\azure-data-tables\azure-data-tables.vcxproj]
2024-09-16T23:19:55.4325862Z          d:\a\_work\1\s\build\sdk\tables\azure-data-tables\predefined c++ types (compiler internal)(33): warning C28285: For function 'new' 'return' syntax error in '(byteCount(__formal(0,_Size)))' near '(byteCount(__formal(0'. [D:\a\_work\1\s\build\sdk\tables\azure-data-tables\azure-data-tables.vcxproj]
2024-09-16T23:19:55.4326868Z 
2024-09-16T23:19:55.4327339Z 
2024-09-16T23:19:55.4328168Z        "D:\a\_work\1\s\build\ALL_BUILD.vcxproj" (default target) (1) ->
2024-09-16T23:19:55.4329289Z        "D:\a\_work\1\s\build\sdk\core\azure-core-test\azure-core-test-fw.vcxproj" (default target) (6) ->
2024-09-16T23:19:55.4330760Z          d:\a\_work\1\s\build\sdk\core\azure-core-test\predefined c++ types (compiler internal)(33): warning C28241: The annotation 'SAL_name' for 'new' on 'return' is not recognized. [D:\a\_work\1\s\build\sdk\core\azure-core-test\azure-core-test-fw.vcxproj]
2024-09-16T23:19:55.4332685Z          d:\a\_work\1\s\build\sdk\core\azure-core-test\predefined c++ types (compiler internal)(33): warning C28285: For function 'new' 'return' syntax error in '("_Ret_notnull_","","2")' near '("_Ret_notnull_",""'. [D:\a\_work\1\s\build\sdk\core\azure-core-test\azure-core-test-fw.vcxproj]
2024-09-16T23:19:55.4334495Z          d:\a\_work\1\s\build\sdk\core\azure-core-test\predefined c++ types (compiler internal)(33): warning C28241: The annotation 'SAL_name' for 'new' on 'return' is not recognized. [D:\a\_work\1\s\build\sdk\core\azure-core-test\azure-core-test-fw.vcxproj]
2024-09-16T23:19:55.4336243Z          d:\a\_work\1\s\build\sdk\core\azure-core-test\predefined c++ types (compiler internal)(33): warning C28285: For function 'new' 'return' syntax error in '("_Post_writable_byte_size_","","2")' near '("_Post_writable_byte_size_",""'. [D:\a\_work\1\s\build\sdk\core\azure-core-test\azure-core-test-fw.vcxproj]
2024-09-16T23:19:55.4338055Z          d:\a\_work\1\s\build\sdk\core\azure-core-test\predefined c++ types (compiler internal)(33): warning C28241: The annotation 'SAL_writableTo' for 'new' on 'return' is not recognized. [D:\a\_work\1\s\build\sdk\core\azure-core-test\azure-core-test-fw.vcxproj]
2024-09-16T23:19:55.4339810Z          d:\a\_work\1\s\build\sdk\core\azure-core-test\predefined c++ types (compiler internal)(33): warning C28285: For function 'new' 'return' syntax error in '(byteCount(__formal(0,_Size)))' near '(byteCount(__formal(0'. [D:\a\_work\1\s\build\sdk\core\azure-core-test\azure-core-test-fw.vcxproj]
2024-09-16T23:19:55.4340685Z 
2024-09-16T23:19:55.4341157Z 
2024-09-16T23:19:55.4341959Z        "D:\a\_work\1\s\build\ALL_BUILD.vcxproj" (default target) (1) ->
2024-09-16T23:19:55.4343066Z        "D:\a\_work\1\s\build\sdk\core\azure-core\test\perf\azure-core-perf.vcxproj" (default target) (10) ->
2024-09-16T23:19:55.4344164Z        "D:\a\_work\1\s\build\sdk\core\perf\azure-perf.vcxproj" (default target) (19) ->
2024-09-16T23:19:55.4345533Z          d:\a\_work\1\s\sdk\core\azure-core\inc\azure\core\internal\json\json.hpp(22020): warning C28241: The annotation 'SAL_name' for 'append_exponent' on 'return' is not recognized. [D:\a\_work\1\s\build\sdk\core\perf\azure-perf.vcxproj]
2024-09-16T23:19:55.4347191Z          d:\a\_work\1\s\sdk\core\azure-core\inc\azure\core\internal\json\json.hpp(22020): warning C28285: For function 'append_exponent' 'return' syntax error in '("_Ret_notnull_","","2")' near '("_Ret_notnull_",""'. [D:\a\_work\1\s\build\sdk\core\perf\azure-perf.vcxproj]
2024-09-16T23:19:55.4348001Z 
2024-09-16T23:19:55.4348384Z 
2024-09-16T23:19:55.4349105Z        "D:\a\_work\1\s\build\ALL_BUILD.vcxproj" (default target) (1) ->
2024-09-16T23:19:55.4350204Z        "D:\a\_work\1\s\build\sdk\storage\azure-storage-files-shares\azure-storage-files-shares.vcxproj" (default target) (56) ->
2024-09-16T23:19:55.4351740Z          d:\a\_work\1\s\build\sdk\storage\azure-storage-files-shares\predefined c++ types (compiler internal)(33): warning C28241: The annotation 'SAL_name' for 'new' on 'return' is not recognized. [D:\a\_work\1\s\build\sdk\storage\azure-storage-files-shares\azure-storage-files-shares.vcxproj]
2024-09-16T23:19:55.4353560Z          d:\a\_work\1\s\build\sdk\storage\azure-storage-files-shares\predefined c++ types (compiler internal)(33): warning C28285: For function 'new' 'return' syntax error in '("_Ret_notnull_","","2")' near '("_Ret_notnull_",""'. [D:\a\_work\1\s\build\sdk\storage\azure-storage-files-shares\azure-storage-files-shares.vcxproj]
2024-09-16T23:19:55.4355436Z          d:\a\_work\1\s\build\sdk\storage\azure-storage-files-shares\predefined c++ types (compiler internal)(33): warning C28241: The annotation 'SAL_name' for 'new' on 'return' is not recognized. [D:\a\_work\1\s\build\sdk\storage\azure-storage-files-shares\azure-storage-files-shares.vcxproj]
2024-09-16T23:19:55.4373968Z          d:\a\_work\1\s\build\sdk\storage\azure-storage-files-shares\predefined c++ types (compiler internal)(33): warning C28285: For function 'new' 'return' syntax error in '("_Post_writable_byte_size_","","2")' near '("_Post_writable_byte_size_",""'. [D:\a\_work\1\s\build\sdk\storage\azure-storage-files-shares\azure-storage-files-shares.vcxproj]
2024-09-16T23:19:55.4406114Z          d:\a\_work\1\s\build\sdk\storage\azure-storage-files-shares\predefined c++ types (compiler internal)(33): warning C28241: The annotation 'SAL_writableTo' for 'new' on 'return' is not recognized. [D:\a\_work\1\s\build\sdk\storage\azure-storage-files-shares\azure-storage-files-shares.vcxproj]
2024-09-16T23:19:55.4476343Z          d:\a\_work\1\s\build\sdk\storage\azure-storage-files-shares\predefined c++ types (compiler internal)(33): warning C28285: For function 'new' 'return' syntax error in '(byteCount(__formal(0,_Size)))' near '(byteCount(__formal(0'. [D:\a\_work\1\s\build\sdk\storage\azure-storage-files-shares\azure-storage-files-shares.vcxproj]
2024-09-16T23:19:55.4479771Z 
2024-09-16T23:19:55.4480729Z 
2024-09-16T23:19:55.4484317Z        "D:\a\_work\1\s\build\ALL_BUILD.vcxproj" (default target) (1) ->
2024-09-16T23:19:55.4485695Z        "D:\a\_work\1\s\build\sdk\keyvault\azure-security-keyvault-administration\azure-security-keyvault-administration.vcxproj" (default target) (36) ->
2024-09-16T23:19:55.4486593Z        (ClCompile target) -> 
2024-09-16T23:19:55.4487827Z          D:\a\_work\1\s\sdk\core\azure-core\inc\azure/core/internal/json/json.hpp(24636,1): fatal  error C1001: Internal compiler error. [D:\a\_work\1\s\build\sdk\keyvault\azure-security-keyvault-administration\azure-security-keyvault-administration.vcxproj]
2024-09-16T23:19:55.4489280Z          D:\a\_work\1\s\sdk\core\azure-core\inc\azure/core/http/policies/policy.hpp(599,1): error C2220: the following warning is treated as an error [D:\a\_work\1\s\build\sdk\keyvault\azure-security-keyvault-administration\azure-security-keyvault-administration.vcxproj]
2024-09-16T23:19:55.4490827Z          D:\a\_work\1\s\sdk\core\azure-core\inc\azure/core/internal/json/json.hpp(24636,1): fatal  error C1001: Internal compiler error. [D:\a\_work\1\s\build\sdk\keyvault\azure-security-keyvault-administration\azure-security-keyvault-administration.vcxproj]
2024-09-16T23:19:55.4491609Z 
2024-09-16T23:19:55.4491801Z 
2024-09-16T23:19:55.4492402Z        "D:\a\_work\1\s\build\ALL_BUILD.vcxproj" (default target) (1) ->
2024-09-16T23:19:55.4493328Z        "D:\a\_work\1\s\build\sdk\tables\azure-data-tables\azure-data-tables.vcxproj" (default target) (18) ->
2024-09-16T23:19:55.4494516Z          D:\a\_work\1\s\sdk\core\azure-core\inc\azure/core/internal/json/json.hpp(24636,1): fatal  error C1001: Internal compiler error. [D:\a\_work\1\s\build\sdk\tables\azure-data-tables\azure-data-tables.vcxproj]
2024-09-16T23:19:55.4495826Z          D:\a\_work\1\s\sdk\core\azure-core\inc\azure/core/http/policies/policy.hpp(599,1): error C2220: the following warning is treated as an error [D:\a\_work\1\s\build\sdk\tables\azure-data-tables\azure-data-tables.vcxproj]
2024-09-16T23:19:55.4496435Z 
2024-09-16T23:19:55.4496695Z 
2024-09-16T23:19:55.4497259Z        "D:\a\_work\1\s\build\ALL_BUILD.vcxproj" (default target) (1) ->
2024-09-16T23:19:55.4498129Z        "D:\a\_work\1\s\build\sdk\core\azure-core-test\azure-core-test-fw.vcxproj" (default target) (6) ->
2024-09-16T23:19:55.4499262Z          D:\a\_work\1\s\sdk\core\azure-core\inc\azure/core/internal/json/json.hpp(24636,1): fatal  error C1001: Internal compiler error. [D:\a\_work\1\s\build\sdk\core\azure-core-test\azure-core-test-fw.vcxproj]
2024-09-16T23:19:55.4500488Z          D:/a/_work/1/s/build/_deps/googletest-src/googletest/include\gtest/gtest-message.h(105,1): error C2220: the following warning is treated as an error [D:\a\_work\1\s\build\sdk\core\azure-core-test\azure-core-test-fw.vcxproj]
2024-09-16T23:19:55.4501067Z 
2024-09-16T23:19:55.4501325Z 
2024-09-16T23:19:55.4501876Z        "D:\a\_work\1\s\build\ALL_BUILD.vcxproj" (default target) (1) ->
2024-09-16T23:19:55.4502715Z        "D:\a\_work\1\s\build\sdk\core\azure-core\test\perf\azure-core-perf.vcxproj" (default target) (10) ->
2024-09-16T23:19:55.4503722Z        "D:\a\_work\1\s\build\sdk\core\perf\azure-perf.vcxproj" (default target) (19) ->
2024-09-16T23:19:55.4504803Z          D:\a\_work\1\s\sdk\core\azure-core\inc\azure/core/internal/json/json.hpp(24636,1): fatal  error C1001: Internal compiler error. [D:\a\_work\1\s\build\sdk\core\perf\azure-perf.vcxproj]
2024-09-16T23:19:55.4506092Z          D:\a\_work\1\s\sdk\core\azure-core\inc\azure/core/internal/json/json.hpp(22059,5): error C2220: the following warning is treated as an error [D:\a\_work\1\s\build\sdk\core\perf\azure-perf.vcxproj]
2024-09-16T23:19:55.4506627Z 
2024-09-16T23:19:55.4506871Z 
2024-09-16T23:19:55.4507416Z        "D:\a\_work\1\s\build\ALL_BUILD.vcxproj" (default target) (1) ->
2024-09-16T23:19:55.4508316Z        "D:\a\_work\1\s\build\sdk\storage\azure-storage-files-shares\azure-storage-files-shares.vcxproj" (default target) (56) ->
2024-09-16T23:19:55.4509534Z          D:\a\_work\1\s\sdk\core\azure-core\inc\azure/core/internal/json/json.hpp(24636,1): fatal  error C1001: Internal compiler error. [D:\a\_work\1\s\build\sdk\storage\azure-storage-files-shares\azure-storage-files-shares.vcxproj]
2024-09-16T23:19:55.4510863Z          D:\a\_work\1\s\sdk\core\azure-core\inc\azure/core/http/policies/policy.hpp(599,1): error C2220: the following warning is treated as an error [D:\a\_work\1\s\build\sdk\storage\azure-storage-files-shares\azure-storage-files-shares.vcxproj]
2024-09-16T23:19:55.4511509Z 
2024-09-16T23:19:55.4511790Z 
2024-09-16T23:19:55.4512411Z        "D:\a\_work\1\s\build\ALL_BUILD.vcxproj" (default target) (1) ->
2024-09-16T23:19:55.4513391Z        "D:\a\_work\1\s\build\sdk\storage\azure-storage-files-datalake\azure-storage-files-datalake.vcxproj" (default target) (51) ->
2024-09-16T23:19:55.4514676Z          D:\a\_work\1\s\sdk\core\azure-core\inc\azure/core/internal/json/json.hpp(24636,1): fatal  error C1001: Internal compiler error. [D:\a\_work\1\s\build\sdk\storage\azure-storage-files-datalake\azure-storage-files-datalake.vcxproj]
2024-09-16T23:19:55.4515327Z 
2024-09-16T23:19:55.4515853Z     26 Warning(s)
2024-09-16T23:19:55.4516449Z     12 Error(s)
2024-09-16T23:19:55.4516769Z 
2024-09-16T23:19:55.4517325Z Time Elapsed 00:09:39.98

[ahsonkhan]

@weshaggard, @scbedd the package releases this week are blocked because of this (for example we have plans to release identity today but the pipelines aren't green). Do you know if the windows images (and the MSVC/visual studio versions) got updated in the last 24-48 hours which might help us narrow what's causing these errors all of a sudden?

[LarryOsterman]

The image override was accidentally removed yesterday, and builds started failing because the underlying issue was not fixed

@weshaggard has reapplied the image override and the builds should start working.

[ahsonkhan]

has reapplied the image override and the builds should start working.

When (and where) did that happen? I am asking because the build is still failing on a re-run.
Are you referring to this or something else?

[weshaggard]

@ahsonkhan I'm working on pinning the image with #5995